-
Notifications
You must be signed in to change notification settings - Fork 30
Add APFPV mode switching #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build locally and tested it on my Runcam VRX. Works as expected, switched between APFPV and wfb-ng from the menu, did a flight with both. |
|
src/wfbcli.cpp
Outdated
| } | ||
| switch (RXMODE) | ||
| { | ||
| case APFPV: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I created a conflict with my other PR. But I think a better way to resolve it would be to not start WFB thread at all in main() (force-set wfb_port to 0 or have a dedicated flag for it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPD just realized that RXMODE can change at runtime...
|
What is keeping this from merging // getting approved? If something still needs to be tested i am happy to help. |
|
Will merge here this weekend if no one vetos. |
|
The GS supports both WFB and AP modes, but the camera requires two different firmware versions, which is very strange. I still maintain that the camera should support both modes simultaneously. I wonder if Igor has changed his mind; perhaps this will be an important step towards promoting dual-mode support for cameras. Additionally, I think using a GS as AP is better than using camera as AP. Multiple cameras can connect to one GS, and laptops can be on the same network as camera. GS can also more easily copy and forward traffic, etc. |
This PR will add APFPV mode switching for SBC 2 beta 2 and greg's APFPV image.
Please remove/uncomment these lines in stream.sh:
apfpv-demo.mp4