fix(storage): invalid storage details cache after writing operations #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enaming/copying/removing/puting Signed-off-by: hcrgm <hcrgm@qq.com>
hcrgm
changed the title
…an error Signed-off-by: hcrgm <hcrgm@qq.com>
KirCute
requested changes
Feb 4, 2026
| details, err, _ := detailsG.Do(storage.GetStorage().MountPath, func() (*model.StorageDetails, error) { | ||
| ret, err := wd.GetDetails(ctx) | ||
| if err != nil { | ||
| Cache.InvalidateStorageDetails(storage) |
Member
There was a problem hiding this comment.
此时Cache中还没有storage的容量信息，该语句产生的效果一定是什么也不做
| if storage.Config().NoCache { | ||
| return nil, nil | ||
| } | ||
| Cache.InvalidateStorageDetails(storage) |
Member
There was a problem hiding this comment.
绝大多数情况下创建文件夹、移动、重命名都不会影响空间占用，不需要删除缓存
| Cache.linkCache.DeleteKey(stdpath.Join(dstKey, srcRawObj.GetName())) | ||
| } | ||
| if !storage.Config().NoCache { | ||
| Cache.InvalidateStorageDetails(storage) |
| Cache.linkCache.DeleteKey(stdpath.Join(dirKey, dstName)) | ||
| } | ||
| if !storage.Config().NoCache { | ||
| Cache.InvalidateStorageDetails(storage) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / 描述
对存储驱动写操作成功后（上传、删除等），清除存储驱动的详情缓存，使容量数据更实时、准确。
Motivation and Context / 背景
发生上传、删除等写入操作后，容量信息没有发生变化，需要重新加载存储、根目录刷新或等缓存自然过期才发生变化。
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签（如无权限或需要的标签不存在，请在描述中说明，管理员将后续处理）。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库（若适用）。