-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(drivers): add Rakuten Drive support #2084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
drivers/rakuten_drive/driver.go
Outdated
| if srcRemote == "" { | ||
| srcRemote = d.toRemotePath(srcObj.GetPath(), srcObj.IsDir()) | ||
| } | ||
| prefix := path.Dir(srcRemote) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can extract it as a function? It was used four times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. Will update this to reduce duplication as well.
drivers/rakuten_drive/driver.go
Outdated
| } | ||
| if strings.HasSuffix(itemPath, "/") { | ||
| isFolder = true | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind moving this part into its own method? It would make the code easier to read and maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion — I’ll update this to reduce duplication.
refactor(rakuten_drive): extract repeated logic into helper methodsDescription / 描述
Motivation and Context / 背景
How Has This Been Tested? / 测试
Checklist / 检查清单
|
feat(rakuten_drive): add Rakuten Drive storage driver
Description / 描述
RakutenDrivedriver with list, link, mkdir, move, rename, copy, delete, upload (S3 multipart), and storage quota support.drivers/all.go.Motivation and Context / 背景
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库(若适用)。