Skip to content

feat(driver): Disable browser caching for local storage downloads #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jenfonro wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(driver): Disable browser caching for local storage downloads #2107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions server/handles/down.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"fmt"
stdpath "path"
"strconv"
"strings"

"github.com/OpenListTeam/OpenList/v4/internal/conf"
"github.com/OpenListTeam/OpenList/v4/internal/driver"
Expand Down Expand Up @@ -71,12 +72,18 @@ func Proxy(c *gin.Context) {
common.ErrorPage(c, err, 500)
return
}
proxy(c, link, file, storage.GetStorage().ProxyRange)
} else {
common.ErrorPage(c, errors.New("proxy not allowed"), 403)
return
// Disable browser caching for local storage downloads.
if isLocalDriver(storage) {
c.Header("Cache-Control", "no-store, no-cache, must-revalidate, max-age=0")
c.Header("Pragma", "no-cache")
c.Header("Expires", "0")
}
proxy(c, link, file, storage.GetStorage().ProxyRange)
} else {
common.ErrorPage(c, errors.New("proxy not allowed"), 403)
return
}
}
}

func redirect(c *gin.Context, link *model.Link) {
defer link.Close()
Expand Down Expand Up @@ -175,3 +182,13 @@ func canProxy(storage driver.Driver, filename string) bool {
}
return false
}

func isLocalDriver(storage driver.Driver) bool {
if storage == nil || storage.GetStorage() == nil {
return false
}
if strings.EqualFold(storage.Config().Name, "Local") {
return true
}
return strings.EqualFold(storage.GetStorage().Driver, "Local")
}