[IntroRemoteDS-pre] Fix and improvements to L3_DataPreparation notebook #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emote-data-science
This commit fixes a few minors in the L3_DataPreparation notebook after coding through the first block of Lecture 3 in Introduction to Remote Data Science pre-release. This commit addresses Issue OpenMined#380 OpenMined#381 OpenMined#382 Moreover: - duplicates in raw_data should be applied inplace - plt.show() whenever a plot is generated to avoid the repr of the Axis object - the plot_extrapolated_country function had a missing import of numpy as np - x = list(range(53)) has been updated as per drop inplace - iloc is used whenever accessing an entry in the DataFrame. (Without iloc, the code doesn't work)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
leriomaggio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a few minors in the
L3_DataPreparation.ipynbnotebookafter coding through the first block of Lecture 3 in Introduction
to Remote Data Science pre-release.
This commit addresses Issue #380 #381 #382
Moreover:
inplaceplt.show()has been added whenever a plot is generated to avoid the repr of the Axis objectimport numpy as npx = list(range(53))has been updated as per drop in-place.ilocis always used whenever accessing an entry in the transposed DataFrame. (Withoutiloc, the code doesn't work -pandas 1.3.3)Checklist