-
Notifications
You must be signed in to change notification settings - Fork 125
OgrFileExport: Exclude objects with hidden or helper symbols #2421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
ChatGPT (and me) propose a better commit message: |
|
I prefer concise commit messages, and so far I prefer to not be bothered with reviewing LLM output. |
|
Hm, noticing a mismatch between function name and function result 🤔 The original design was: But the "per-symbol layers" export doesn't use the curated list when populating the layers. |
|
@dg0yt: thank you for your feedback. That led me to reconsider the current solution, and I believe I’ve found a more elegant approach. |
|
Now merging everything in an unified approach. |
d7aa30a to
870b977
Compare
|
Retriggering CI. |
|
Note: the issue does not affect the .dxf export, independent of the "Create a layer for each symbol" setting. It does however affect .shp export, therefore I added another test (which will fail without this fix). |
The geospatial vector export shall not export objects with hidden or helper symbols. However, if the "Create a layer for each symbol" setting in the GDAL/OGR configuration was not set then objects with hidden or helper symbols would not be excluded.
Merge the code sections for creating one layer per symbol and one layer per symbol type.
ae870e2 to
b1b1c9d
Compare
b1b1c9d to
6aa6fe5
Compare
The geospatial vector export shall not export objects with hidden or helper symbols.
However, if the "Create a layer for each symbol" setting in the GDAL/OGR configuration was not set then objects with hidden or helper symbols would not be excluded.