Open PROT changes to pldm-lib. #2
Conversation
…ceholder member functions. IPC calls will be placed into their bodies and fd_internal as well as fd_ops content will be moved to a fd Hubris driver task.
| #[derive(Debug, Copy, Clone, PartialEq)] | ||
| #[repr(C)] | ||
| #[derive(FromBytes, IntoBytes)] | ||
| //#[repr(C)] |
There was a problem hiding this comment.
I haven't checked in depth what triggered this change.
Is the layout of this type critical for (de)serialization?
There was a problem hiding this comment.
This is a good question. I can't say why this changed was made. It may have been a co-pilot adjustment. I'll change it back.
There was a problem hiding this comment.
Is this inteded as another package?
Then this belongs in its on directory with its own /src/lib.rs.
There was a problem hiding this comment.
This should be removed completely if not needed.
If some timer interface is needed, maybe use a dedicated crate for that.
(for example embedded-timers)
| [workspace] | ||
| members = [ | ||
| "pldm-common" | ||
| ] |
There was a problem hiding this comment.
Moving pldm-lib into its own directory and adding it to the workspace members might be cleaner and probably better for packaging releases.
There was a problem hiding this comment.
I have thought about that, but I want to keep pldm-common as part of pldm-lib. Don't we want pldm-common to exist within pldm-lib?
2 participants
Async executor removed. Firmware device api, fd_ops and fd_internal, will be in a Hubris driver task.