Add adocs: add Amer Shamlan to contributors listmer contribution#901
Add adocs: add Amer Shamlan to contributors listmer contribution#901Amer-css wants to merge 3 commits intoOpenSource-Communities:mainfrom
Conversation
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this pull request is meant to address.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
adiati98
left a comment
There was a problem hiding this comment.
Hey @Amer-css,
Thanks for your PR! ✨
I see that there's duplication in the file, and they're not in the right place.
Please follow the instructions in our course to contribute to this repo.
Also, you need to add a description and link your issue in the PR body.
Description
What type of PR is this? (check all applicable)
Related Issues
Contributors Checklist
I've read through the Getting Started section
Have you run
npm run contributors:generateto generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?