Skip to content

Conversation

@ernestognw
Copy link
Member

Just removing old mentions of ERC7702

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@ernestognw ernestognw requested a review from a team as a code owner November 3, 2025 16:56
@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025

⚠️ No Changeset found

Latest commit: 20febd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

Walkthrough

This pull request systematically renames ERC7702 terminology to EIP7702 across contracts, tests, and documentation. Mock contract classes are renamed (AccountERC7702Mock → AccountEIP7702Mock, AccountERC7702WithModulesMock → AccountEIP7702WithModulesMock), test contracts and helper classes are updated accordingly (AccountERC7702Test → AccountEIP7702Test, ERC7702SmartAccount → EIP7702SmartAccount), and documentation references are adjusted. Additionally, the upgradeable patch introduces EIP712 refactoring with new internal view functions (_EIP712NameHash, _EIP712VersionHash), removes the ReentrancyGuard constructor, and updates test fixtures and package references.

Possibly related PRs

Suggested labels

breaking change, ignore-changeset

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'Remove ERC7702 mentions in favor of EIP7702' clearly and accurately summarizes the main objective of the changeset. The title directly reflects the primary change across all modified files, which involves systematic renaming of ERC7702-related identifiers to EIP7702-related identifiers throughout contracts, tests, mocks, documentation, and helper files. The title is concise, specific, and provides sufficient context for developers scanning the history.
Description check ✅ Passed The pull request description 'Just removing old mentions of ERC7702' is related to the changeset and accurately describes the nature of the changes, even though it is brief. The description correctly identifies the primary objective of removing outdated ERC7702 terminology in favor of EIP7702 across the codebase. While the description could be more detailed, it is not vague or completely unrelated to the work being performed.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8631702 and df2e01a.

📒 Files selected for processing (9)
  • certora/harnesses/AccountHarness.sol (1 hunks)
  • contracts/mocks/account/AccountMock.sol (2 hunks)
  • contracts/mocks/docs/account/MyAccountEIP7702.sol (2 hunks)
  • docs/modules/ROOT/pages/eoa-delegation.adoc (1 hunks)
  • scripts/upgradeable/upgradeable.patch (1 hunks)
  • test/account/AccountEIP7702.t.sol (3 hunks)
  • test/account/AccountEIP7702.test.js (2 hunks)
  • test/account/examples/AccountEIP7702WithModulesMock.test.js (2 hunks)
  • test/helpers/erc4337.js (2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: ernestognw
Repo: OpenZeppelin/openzeppelin-contracts PR: 5904
File: contracts/crosschain/README.adoc:1-1
Timestamp: 2025-08-28T15:48:30.716Z
Learning: ernestognw prefers "Cross chain" without hyphenation rather than "Cross-chain" in documentation titles.
📚 Learning: 2025-10-15T02:52:05.027Z
Learnt from: ernestognw
Repo: OpenZeppelin/openzeppelin-contracts PR: 5891
File: test/account/modules/ERC7579Module.behavior.js:56-61
Timestamp: 2025-10-15T02:52:05.027Z
Learning: In ERC7579 validator tests for `isValidSignatureWithSender`, using `this.mock` (not bound to a specific account) is valid when testing signature validation with any arbitrary sender, while `this.mockFromAccount` is used when testing account-specific validation scenarios.

Applied to files:

  • certora/harnesses/AccountHarness.sol
  • contracts/mocks/account/AccountMock.sol
  • test/account/examples/AccountEIP7702WithModulesMock.test.js
  • test/account/AccountEIP7702.test.js
  • test/account/AccountEIP7702.t.sol
  • contracts/mocks/docs/account/MyAccountEIP7702.sol
  • scripts/upgradeable/upgradeable.patch
📚 Learning: 2025-08-29T13:16:08.640Z
Learnt from: Amxx
Repo: OpenZeppelin/openzeppelin-contracts PR: 5904
File: contracts/mocks/crosschain/ERC7786RecipientMock.sol:12-14
Timestamp: 2025-08-29T13:16:08.640Z
Learning: In OpenZeppelin contracts, mock contracts (like ERC7786RecipientMock) don't require input validation such as zero-address checks in constructors, as they are only used for testing purposes in controlled environments.

Applied to files:

  • certora/harnesses/AccountHarness.sol
  • contracts/mocks/account/AccountMock.sol
  • test/account/examples/AccountEIP7702WithModulesMock.test.js
  • test/account/AccountEIP7702.test.js
  • test/account/AccountEIP7702.t.sol
🧬 Code graph analysis (2)
test/account/examples/AccountEIP7702WithModulesMock.test.js (1)
test/account/AccountEIP7702.test.js (4)
  • mock (22-22)
  • helper (21-21)
  • entrypointDomain (25-25)
  • domain (28-33)
test/account/AccountEIP7702.test.js (1)
test/account/examples/AccountEIP7702WithModulesMock.test.js (4)
  • mock (30-32)
  • helper (29-29)
  • entrypointDomain (35-35)
  • domain (38-43)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Redirect rules - solidity-contracts
  • GitHub Check: Header rules - solidity-contracts
  • GitHub Check: Pages changed - solidity-contracts
  • GitHub Check: slither
  • GitHub Check: tests-foundry
  • GitHub Check: coverage
  • GitHub Check: tests
  • GitHub Check: tests-upgradeable
  • GitHub Check: halmos
🔇 Additional comments (1)
test/helpers/erc4337.js (1)

112-117: The rename to eip7702signer is complete with no stale usages.

The review comment's concern about existing callers using the old parameter name erc7702signer is unfounded. Search results confirm:

  • Zero usages of the old name erc7702signer anywhere in the codebase
  • All call sites (AccountEIP7702.test.js:22 and AccountEIP7702WithModulesMock.test.js:31) already use the new name eip7702signer
  • The parameter is used consistently throughout the implementation (lines 112, 114, 115)

The migration is complete and clean. No backward-compatible alias is needed, and all usages have already been updated. The code is in a stable state.

Likely an incorrect or invalid review comment.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Amxx Amxx changed the base branch from master to typo-fixes November 5, 2025 16:45
@Amxx Amxx merged commit 2518fbd into OpenZeppelin:typo-fixes Nov 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants