Test all multiply kernels in CI #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilectra
reviewed
Nov 30, 2023
Contributor
Author
|
I hope this makes more sense now that I've also removed the files of |
ilectra
approved these changes
Nov 30, 2023
It will get set by the GHA workflow instead
tkoskela
added
area: testing
Contributor
Author
|
Following on from our meeting today, are we ok to merge this? @davidbowler |
Contributor
|
Yes, I think so - but why are we removing the OpenMP directives in the |
davidbowler
approved these changes
Jan 16, 2024
Contributor
davidbowler
left a comment
davidbowler
left a comment
There was a problem hiding this comment.
Fine to go though I'd like to understand the change in ompDoji
Contributor
Author
|
Yes, OpenMP directives that were removed were redundant because the parallel region has been moved to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #270
Also contains bug fixes to multiply kernels discovered during testing.
By default the CI workflow only runs the default multiply kernel and excludes the rest, but you can dispatch the workflow manually and set multiply_kernel_test = true to run all the multiply kernels in the matrix. Unfortunately this is difficult to test until the change is in the default branch because of how the GitHub GUI works. You used to be able to manually dispatch from branches using the CLI, but the information seems to be gone from the page so it might have been removed.