Implement surface dipole correction #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added calculation of surface dipole to density_module.f90, along with call from get_H_on_atomfns and small change to grid_index to allow grid point positions to be a target. This does not yet include energy or force/stress calculations.
Input parameters now read, and small error corrected: the formula given by Bengtsson does not include an explicit shift to place the discontinuity in the vacuum, though it is implied (and should be there!).
This had not been kept up-to-date, so needed a fast-forward. Implementation wasn't quite right (difference between the two key papers) but is now complete. Just needs documentation.
Small changes to tidy up potential and output, and added outline documentation
davidbowler
added
area: main-source
The .gitignore file directs all Conquest_o* files to be ignored so Conquest_out.ref needs to be added with -f
tsuyoshi38
approved these changes
Feb 24, 2025
Contributor
tsuyoshi38
left a comment
tsuyoshi38
left a comment
There was a problem hiding this comment.
Let me ask you one question.
The subroutines like get_band_density in density_module.f90 are also removed, since they are now done in PostProcess, I guess. Am I correct ?
The code for surface dipole correction looks good.
(Can we also treat "charged state" ? )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the surface dipole correction for slab calculations of Neugebauer and Scheffler (PRB 46 16067 (1992)) and Bengtsson (PRB 59 12,301 (1999)). Requires user to specify direction of surface normal and optionally location of dipole correction (in vacuum). Enables output of average electrostatic potential in specified direction (with or without dipole correction). Also added documentation and test for calculation with dipole.