[WIP-do not merge!] Add theme definitions table to Data Guides #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `theme-definitions.json` with structured descriptions of all data themes (based on the [Definitions Proposal](https://lf-overturemaps.atlassian.net/wiki/spaces/PROJ/pages/353927169/Definitions+Proposal)) - Added `theme-definitions.mdx` page under /guides to display the themes table - Introduced `ThemesTable` React component for rendering and styling the table Note: Theme definitions are still incomplete and may contain errors.
FlorianNachtigall
force-pushed
the
theme-definitions
branch
from
b0b50da to
0509cb7
Compare
FlorianNachtigall
temporarily deployed
to
staging
GitHub Actions
Inactive
stepps00
reviewed
Nov 20, 2025
| "url": "https://www.apache.org/licenses/LICENSE-2.0" | ||
| } | ||
| ], | ||
| "sources": [ |
Contributor
There was a problem hiding this comment.
We now maintain AllThePlaces and RenderSEO data for places and the list will continue to grow each release. Since we also have the Attribution and Licensing page and source json files (places example), would it be worth linking out to one of these lists, rather than maintain it separately here?
Contributor
There was a problem hiding this comment.
agree. I'll probably do that after we publish the initial version of this table.
stepps00
reviewed
Nov 20, 2025
stepps00
reviewed
Nov 20, 2025
wagnerfe
reviewed
Nov 20, 2025
| "freshness": "", | ||
| "type": "commercial", | ||
| "url": "" | ||
| } |
There was a problem hiding this comment.
we have added Krick as a commercial provider
Contributor
- Fix license name formatting - Update address definition (GERSified, coverage, quality) - Correct any fields transferred incorrectly from the wiki - Render merging summary as list
FlorianNachtigall
temporarily deployed
to
staging
GitHub Actions
Inactive
danabauer
changed the title
danabauer
force-pushed
the
theme-definitions
branch
from
a9b4143 to
8540c19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Create an overview table for data themes based on the Definitions Proposal.
Proposal
theme-definitions.jsonas the single source of truth for all data theme and data type definitions that extend beyond schema specifications.themesTable.jsreact component to render a table which can be expanded to show full definitions, while providing an aggregate view for comparing definitions and characteristics across themes.Know issues
ToDos
freshness,quality_assuranceandfilteringfieldsDocs Preview:
Click the most recent "View Deployment"
All Staging Deployments