Skip to content

Conversation

@JaimieWi
Copy link
Contributor

Lets Encrypt workflow

What is being addressed

Pull in change to Deployment Repo - microsoft/AzureTRE#3979
Fix Lets Encrypt workflow

How is this addressed

Pulled in description from above PR:

See details of issue, but in summary to fix the lets_encrypt.yml GitHub Action:

missing variable:
AZURE_ENVIRONMENT
values of the following variables were the wrong way around:
ARM_SUBSCRIPTION_ID
ARM_TENANT_ID
following variables needed passing in TF_VAR_varname form:
TERRAFORM_STATE_CONTAINER_NAME
MGMT_RESOURCE_GROUP_NAME
MGMT_STORAGE_ACCOUNT_NAME

In addition, the following minor changes were made:

  • Add an environment selector to the workflow_dispatch, to allow users to run for different environments other than CICD.
  • Commented out the schedule dispatch - I can see its perpetually failing on microsoft/AzureTRE, suggest its left up to forkers to determine whether to run on a schedule and for which environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants