refactor(update): 迁移并重构更新逻辑 #2282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcl-ce-automation
bot
added
🛠️ 等待审查
ruattd
requested changes
Jan 23, 2026
Contributor
ruattd
left a comment
ruattd
left a comment
There was a problem hiding this comment.
从 VB 把史山 Copy-Paste 到 C# 没什么意义
我衷心建议你去读读别的优秀开源项目源码，自己写写实际项目沉淀一下，再考虑动 CE 的核心设施
以及，你起名字的能力确实不太够，要不借助一下 AI？
Comment on lines
+21
to
+25
| /// <summary> | ||
| /// 下载更新文件 | ||
| /// </summary> | ||
| /// <param name="outputPath">输出路径</param> | ||
| public Task<bool> DownloadAsync(string outputPath); |
|
|
||
| public string SourceName => name; | ||
|
|
||
| private static readonly string _TempPath = Path.Combine(FileService.TempPath, "Cache", "Update"); |
Contributor
There was a problem hiding this comment.
《TempPath》《Cache》《Update》
很难不让人怀疑你在把缓存目录当数据目录用
Contributor
There was a problem hiding this comment.
这个实现里我注意到了很多抛出的异常，你在上层有健全的异常处理来利用这个抛出异常的机制吗，还是仅仅把它直接丢给 Lifecycle 或 UI 层的保底处理？
这里抛出异常这种设计本身就不是很合理，况且一般使用这种设计传递信息都是会自定义异常的，然而你抛的都是stdlib 自带的异常
Comment on lines
+66
to
+78
| _LogTrace("开始获取版本信息"); | ||
| var channelName = Config.System.Update.UpdateChannel switch | ||
| { | ||
| 0 => "sr", | ||
| 1 => "fr", | ||
| _ => "sr" | ||
| } + (RuntimeInformation.ProcessArchitecture == Architecture.Arm64 ? "arm64" : "x64"); | ||
|
|
||
| var assets = await _GetRemoteInfoByNameAsync<VersionAssetsDataModel>( | ||
| $"updates-{channelName}", "updates/").ConfigureAwait(false); | ||
| _LogTrace("版本信息获取完成"); | ||
|
|
||
| ret = assets?.Assets.FirstOrDefault(); |
Contributor
There was a problem hiding this comment.
目前更新是打算改成逐层检查的逻辑的，这里仍然用了传统的逻辑，而且这段逻辑可以复用吧
Comment on lines
+60
to
+63
| public Task<AnnouncementsListModel> GetAnnouncementAsync() | ||
| { | ||
| throw new NotSupportedException("MirrorChyan 更新源不支持公告功能"); | ||
| } |
Contributor
There was a problem hiding this comment.
为什么不直接设计成返回 nullable 呢，这点 unsupported 的破事都要抛个异常，不就是把史山直接搬过来了
Comment on lines
+123
to
+125
| _LogInfo("开始下载更新文件"); | ||
| var manager = new DownloadManager(new FastMirrorSelector(NetworkService.GetClient())); | ||
| await manager.DownloadAsync(task, CancellationToken.None).ConfigureAwait(false); |
Contributor
There was a problem hiding this comment.
虽然不知道这个下载器支不支持但是提个醒，这个下载源最好限制单线程
Comment on lines
+244
to
+248
|
|
||
| /// <summary> | ||
| /// 已显示的启动器公告。 | ||
| /// </summary> | ||
| [ConfigItem<string>("SystemSystemAnnouncement", "", ConfigSource.Local)] public partial string ShowedAnnouncement { get; set; } |
Contributor
There was a problem hiding this comment.
你这个 RemoteInfo 干的事跟这个名字八竿子打不着
|
|
||
| [LifecycleService(LifecycleState.BeforeLoading)] | ||
| public sealed class UpdateService : GeneralService | ||
| [LifecycleScope("update", "处理更新参数")] |
Contributor
Author
|
唉...我应该再关PR再次重写 |
pcl-ce-automation
bot
removed
🛠️ 等待审查
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.