ListWorksheetInfo Improvements for Xlsx and Ods #4746
Merged
+74
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3255, another oldie (3+ years). Allow the ability to only count rows and columns with data. To avoid a breaking change, keep present logic unless Reader
readEmptyCellsattribute is set to its non-default value, i.e.false. This adds very little overhead, and gives a result that I think many users would prefer.It was natural to look at the equivalent code for Ods while doing this. That code turned out to be buggy. Changes there are a bugfix, so I am not concerned about BC breaks, and therefore return what I think most users would want without the need for differing results depending on
readEmptyCells.This is:
Checklist: