Fix: #issue76161: error C2440 of 'static_cast': cannot convert from 'InType' to 'OutType'

[Manfredss]

PR Category

Environment Adaptation

PR Types

Bug fixes

Description

fix compile error in paddle/phi/core/framework/data_type_transform.cc

• Windows ninja 报错：error C2440: 'static_cast': cannot convert from 'InType' to 'OutType' #76161

before:

 template <typename InType, typename OutType>
 struct CastDataTypeFunctor {
   HOSTDEVICE inline OutType operator()(InType in) const {
     return static_cast<OutType>(in);
  }
};

after:

template <typename InType, typename OutType>
struct CastDataTypeFunctor {
  HOSTDEVICE inline OutType operator()(InType in) const {
    #if defined(_MSC_VER)
        // Avoid unsupported convert of float/bfloat8/float16 -> complex for MSVC
        if constexpr (
            (std::is_same_v<OutType, phi::dtype::complex<float>> ||
            std::is_same_v<OutType, phi::dtype::complex<double>>) &&
            (std::is_same_v<InType, phi::dtype::float8_e4m3fn> ||
            std::is_same_v<InType, phi::dtype::float8_e5m2> ||
            std::is_same_v<InType, phi::dtype::bfloat16> ||
            std::is_same_v<InType, phi::dtype::float16>)) {
          return OutType(0);  // default return value，only to avoid compile error
        } else
    #endif
        {
          return static_cast<OutType>(in);
        }
      }
};

[paddle-bot]

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

[Manfredss]

#76171 提交的 branch 上有太多历史 commit 没有解决，决定单独重开一个 PR
对 #76161 的 bug 修复

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@b9e19ab). Learn more about missing BASE report.

Additional details and impacted files

@@             Coverage Diff             @@
##             develop    #76185   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         1           
  Branches           ?         0           
===========================================
  Hits               ?         1           
  Misses             ?         0           
  Partials           ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[luotao1]

hi, @Manfredss

• 非常感谢你对飞桨的贡献，我们正在运营一个PFCC组织。PFCC是飞桨开源的贡献者俱乐部，只有给飞桨合入过代码的开发者才能加入，俱乐部里每两周会有一次例会（按兴趣参加），也会时不时办线下meetup面基，详情可见 https://github.com/luotao1 主页说明。
• 如果你对PFCC有兴趣，请发送邮件至 [email protected]，我们会邀请你加入~