Skip to content

Conversation

@yannicklamprecht
Copy link
Contributor

No description provided.

@jpenilla
Copy link
Member

jpenilla commented Jan 12, 2026

I think we want to use a pinned VF snapshot for now to fix some of this without patches (you can see in the git history we did this for a version recently if you need an example)

@Toffikk
Copy link

Toffikk commented Jan 12, 2026

though the latest vf snapshot causes a lot more compile issues and requires a lot more patches than what is done here, i already reported two issues that should, when resolved, make 1.12.0 a viable version for mache to switch to, cuz rn it just requires way too many fixes

@yannicklamprecht yannicklamprecht force-pushed the snapshot/26.1-snapshot-1 branch from f207bf4 to 591575f Compare January 12, 2026 21:05
@yannicklamprecht
Copy link
Contributor Author

though the latest vf snapshot causes a lot more compile issues and requires a lot more patches than what is done here, i already reported two issues that should, when resolved, make 1.12.0 a viable version for mache to switch to, cuz rn it just requires way too many fixes

Less patches but instead we get one really big one. https://github.com/PaperMC/mache/compare/f207bf438c506886da54d26975a09cc83060bad6..591575f29300ba7244d3944a51f2a2e3fcfe867d#diff-8bd557c27fdae2ff59de9afb33d2e0b669af01dc2224757358339e2cce5889c6

@MiniDigger
Copy link
Member

we wanna wait for Vineflower/vineflower#532 before we touch snapshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants