Remove 25 unused/obsolete translation keys #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed keys: - admin.comment - api_tokens.added_date - attachment.external_file - attachment.table.filename - datatable.datatable.lengthMenu - delete.caption - edit.caption_short - part.add.caption - part.add.comment - part.description.placeholder - part.edited_flash.invalid - part.instock.placeholder - part.mininstock.placeholder - part.order.price_per - part.withdraw.btn - part.withdraw.caption - part.withdraw.comment: - project.caption - r_u2f_two_factor.name - search.deactivateBarcode - selectpicker.empty - supplier.caption - tfa_u2f.key_added_successful - tree.root_node.text - validator.part_lot.location_full.no_increasment (typo of fixed key) These keys have zero occurrences in the codebase and are safe to remove. Co-authored-by: jbtronics <[email protected]>
Copilot
AI
changed the title
[WIP] Remove unused and obsolete translations from codebase
Remove 25 unused/obsolete translation keys
Dec 5, 2025
Member
|
@copilot Do not trust the obsolete annotation, check it for yourself |
Contributor
Author
I re-verified each of the 25 removed keys by searching the codebase thoroughly (PHP, Twig, YAML, JS files). None of them have any occurrences in the code:
All removals have been verified independently of the "obsolete" annotations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many translation keys in the XLIFF files have become obsolete over time as the codebase evolved. This PR removes keys with zero occurrences in the codebase.
Approach
messages.en.xlflog.type.*,perm.*,settings.*,m_status.*, etc.)Removed Keys
admin.comment,delete.caption,edit.caption_short,tree.root_node.textpart.add.caption,part.add.comment,part.withdraw.btn,part.withdraw.caption,part.withdraw.comment:,part.description.placeholder,part.instock.placeholder,part.mininstock.placeholderproject.caption,supplier.captiondatatable.datatable.lengthMenu,search.deactivateBarcode,selectpicker.emptyapi_tokens.added_date,attachment.external_file,attachment.table.filename,part.edited_flash.invalid,part.order.price_per,r_u2f_two_factor.name,tfa_u2f.key_added_successfulvalidator.part_lot.location_full.no_increasment→ key was fixed tono_increaseVerification
Each removed key was verified to have zero occurrences across all source files. For example:
part.withdraw.btn/caption/comment:are distinct from the used keys (part.withdraw.success,part.withdraw.zero_amount,part.withdraw.access_denied)part.description.placeholderis distinct from the usedpart.edit.description.placeholderr_u2f_two_factor.nameis distinct from the usedr_u2f_two_factor.pressbuttonImpact
~300 translation entries removed across 14 language files (~3,000 lines).
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.