Prevent password leak in memory #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and prevent it from being leaked in memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR; Call spec.clearPassword() to clear the internal copy of the password and prevent it from being leaked in memory.
See https://docs.oracle.com/javase/8/docs/api/javax/crypto/spec/PBEKeySpec.html
The plain text password is not cleared from memory after being used for key derivation in internalHash. This may leave sensitive data in memory longer than necessary, increasing the risk of exposure via memory dumps. After generating the secret key, we clear the sensitive password data from memory by refactoring the code to use a try-finally block that calls spec.clearPassword() after secretKeyFactory.generateSecret(spec).
Additional details and PoC available on request.