Open
Conversation
add support for glory generation add UI for glory generation
…OfBuilding-PoE2 into glory-generation pull from upstream dev
LocalIdentity
requested changes
Sep 24, 2025
Contributor
LocalIdentity
left a comment
LocalIdentity
left a comment
There was a problem hiding this comment.
Missing mods
- Consuming Glory grants you 3% increased Attack damage per Glory consumed for 6 seconds, up to 60%
- Banners gain 5 Glory per second
- Skills have a (10-15)% chance to not consume Glory
- Skills have a 5% chance to not consume Glory
- Skills gain 1 Glory every 2 seconds for each Rare or Unique monster in your Presence
- Daresso's Passion
- Spear of Solaris
- Ancestral Cry
| ["active_skill_requires_X_glory"] = { | ||
| skill("gloryCost", nil), | ||
| }, | ||
| ["active_skill_generates_mp_%_glory_per_attack_hit"] = { |
Contributor
There was a problem hiding this comment.
Missing Glory mods for active_skill_generates_mp_%_glory_per_heavy_stun on Hammer of the Gods and Spear of Solaris,
Contributor
Author
There was a problem hiding this comment.
True, but I don't know how to display anything meaningful for those.
The intent was to display something meaningful for players with a banner, because it's very hard to gauge as a player.
The heavy stun mechanic is much more predictable, because a warrior will already know how often he stuns.
rename variables move display from sidebar to calc fix hitrate and accuracy for banner glory/s
rename variable in parser add ShowGlory flag to toggle display on attacks
…OfBuilding-PoE2 into glory-generation merge dev into branch
Contributor
Author
|
Resolved the rest of the issues. |
fix passive glory not scaling with increases
add glory to resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Glory now parses.
Skills with ["active_skill_requires_X_glory"] now display a glory cost.
The monster-power glory-gain mod applies a global effect that apply to attack skills.
As such, all attack skills get "Banner glory per second" while the user has a banner, which is better than nothing to me.
(product of mod, speed and a constant acting as monster power)
Steps taken to verify a working solution:
Link to a build that showcases this PR:
maxroll
Before screenshot:
Red text.
After screenshot:
Normal attack skills:
Glory-consuming attack skills:
