Skip to content

DPS calculation for Storm-spells and other similar skills #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrHB212 wants to merge 2 commits into from
Closed

DPS calculation for Storm-spells and other similar skills #1745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a42815c
skillstatmap and calcoffence adjustment
MrHB212 Jan 20, 2026
d8d4689
Update CalcOffence.lua
MrHB212 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/Data/SkillStatMap.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,26 @@ return {
skill("durationSecondary", nil),
div = 1000,
},
["fire_storm_fireball_delay_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
["lightning_storm_hit_prevention_duration_ms"] = {
skill("maxHitRate", nil),
div = 1000,
},
["rain_of_arrows_delay_per_arrow"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
["lightning_storm_hit_frequency_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
["rain_hit_delay_ms"] = {
skill("maxHitRate", nil),
div = 1000,
},
["base_tertiary_skill_effect_duration"] = {
skill("durationTertiary", nil),
div = 1000,
Expand Down
7 changes: 6 additions & 1 deletion src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2708,7 +2708,7 @@ function calcs.offence(env, actor, activeSkill)
output.Cooldown = globalOutput.Cooldown
output.Speed = m_min(output.Speed, 1 / output.Cooldown * output.Repeats)
end
if output.Cooldown and skillFlags.selfCast then
if (output.Cooldown and skillFlags.selfCast) or (SkillType.Sustained) then
skillFlags.notAverage = true
skillFlags.showAverage = false
skillData.showAverage = false
Expand Down Expand Up @@ -2830,7 +2830,12 @@ function calcs.offence(env, actor, activeSkill)
end

end

if skillData.hitTimeOverride and not skillData.triggeredOnDeath then
--checks if skill has a max hit rate per enemy and adjust hitTimeOverride
if skillData.maxHitRate and skillData.hitTimeOverride < skillData.maxHitRate then
skillData.hitTimeOverride = skillData.maxHitRate
end
output.HitTime = skillData.hitTimeOverride
output.HitSpeed = 1 / output.HitTime
--Brands always have hitTimeOverride
Expand Down