-
Notifications
You must be signed in to change notification settings - Fork 221
Demo: Active volume #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Demo: Active volume #1618
Conversation
|
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
Your preview is ready 🎉!You can view your changes here
|
Qottmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool demo! I really like the approach of explaining the compilation with a concrete example, makes it so much easier to follow!
I feel like the introduction could be significantly reduced, as it hints at a lot of things that at this stage make it more confusing than helpful (in particular when talking about new concepts are that are not yet introduced).
It's really good to have a lot of visual representations explaining the concepts rather intuitively. Sometimes these could be used more generously (i.e.: wouldnt hurt to add even more more visualizations! 😎 )
I read the paper a while ago so I already forgot a lot of things, so saw this with relatively fresh eyes. I highlight the many points of confusion I encountered (which was a lot given the complexity of the topic)
I think logical blocks are not introduced anywhere? Its sometimes confusing what is being referred to (blocks, vertices, qubits,..?)
Its a bit weird that we're talking about an active volume quantum computer but dont say what that refers to. I'd either informally explain it, or not use the term. For the latter, from reading the demo it is not clear that I need any special properties of my QC to be able to perform all these operations in principle. Are there fundamental restrictions? Or is it just a matter of having the necessary software framework to create directed ZX diagrams, connect them in the right manner and track measuremtn dependent corrections?
|
Thanks for the thorough review @Qottmann
This is not addressed yet. Maybe the other sections can settle a bit and then the introduction can be adjusted to that :)
I added a bit more, but not crazy much.
They are introduced, when formally introducing logical networks after oriented ZX diagrams. I tried to be more clear about it being something that will be introduced later whenever they are referenced before.
I removed almost all uses of "vertex" and replaced them by "spider" instead. I hope that helps.
I added an info box :)
The AV computer abstraction is crucial for the cost model. We could just pass a circuit to a QC and have it execute that gate-by-gate, but AV compilation wants to compress the computation, lowering the cost compared to this baseline approach. In order to form a cost model that tells us whether we actually make something cheaper, we need to assume certain operations to be super cheap compared to others. Those assumptions then are the "AV computer". With the info box added and referenced throughout the demo, I hope that these points come across :) |
Qottmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks already pretty good! 🚀 I'm still being a bit of a pain in the a.. about some concrete points, sorry about that 😬 For some, I'm genuinly confused, other suggestions are in the spirit of making this very complex topic as accessible as possible.
_static/demonstration_assets/active_volume/example-parallelized-explicitly.png
Outdated
Show resolved
Hide resolved
dime10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dwierichs, I really like all the edits you added 🙌
I left some comments above of the final issues I noticed, but we're good shape.
Qottmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome demo 👨🍳 👌 congrats @dwierichs and @dime10 , this is going to be super useful!
Just two cosmetic suggestions, otherwise looks good to me and happy to approve at this point :)
Title: Active volume
Summary:
Introduces the framework from arXiv:2211.15465 for active volume-aware compilation.
Walks through the compilation of an exemplary Clifford circuit, showcasing the concepts of oriented ZX diagrams and logical networks. Complemented by explanations of reactive measurements/reaction time and state teleportation.
Relevant references:
https://arxiv.org/abs/2211.15465
Possible Drawbacks:
Related GitHub Issues:
If you are writing a demonstration, please answer these questions to facilitate the marketing process.
GOALS — Why are we working on this now?
Strong fault-tolerant compilation framework of broad interest
AUDIENCE — Who is this for?
Researchers/students in quantum compilation and/or error correction.
KEYWORDS — What words should be included in the marketing post?
(more details here)