Elastic index lifecycle management politics support #3546
+685
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Philippus Are there any problems to merge this PR ? |
Philippus
requested changes
Oct 5, 2025
| RolloverHandlers | ||
| } | ||
| import com.sksamuel.elastic4s.handlers.indexlifecyclemanagement.IndexLifecycleManagementHandlers | ||
| import com.sksamuel.elastic4s.handlers.indexlifecyclemanagement.IndexLifecycleManagmentHandlers |
There was a problem hiding this comment.
IndexLifecycleManagementHandlers is the correct spelling.
|
|
||
| case class IndexLifecyclePolicy( | ||
| name: String, | ||
| phases: List[IndexLifecyclePolicyPhase], |
There was a problem hiding this comment.
I think maybe a Map is more appropriate here? Then you don't need to override the equals method.
There was a problem hiding this comment.
The idea of this solution is that the user can use only the phases that exist in the API. The user should use the phase enumeration rather than create the phases themselves. Therefore, Map will not help here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented DSL for Index Lifecycle management politcs