Skip to content

refactor: [PPT-2299] optimize booking queries with composite indexes … #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
naqvis wants to merge 1 commit into from
Closed

refactor: [PPT-2299] optimize booking queries with composite indexes … #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/controllers/bookings.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,8 @@ class Bookings < Application
query = query.where(deleted: deleted_flag)

unless include_checked_out
# query = checked_out_flag ? query.where("checked_out_at != ?", nil) : query.where(checked_out_at: nil)
query = checked_out_flag ? query.where("(bookings.checked_out_at IS NOT NULL OR bookings.checked_out_at != ?)", nil) : query.where("(bookings.checked_out_at IS NULL OR bookings.checked_out_at = ?)", nil)
# Simplified: IS NULL already covers the case, no need for redundant OR condition
query = checked_out_flag ? query.where("bookings.checked_out_at IS NOT NULL") : query.where(checked_out_at: nil)
end

total = query.count
Expand Down
Loading