Actually fix Cobalion shiny check #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've retested and it should be good to go again. Here's a clip of the intended route (1x respawn route, 1x shiny check): 2026-01-13.19-16-28.mp4 |
Collaborator
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of the
context.wait_for_all_requests()had broken part of the route for checking Cobalion by changing the last part of the route from a sprint to a walk, which is probably what was responsible for some reports of problems with the beta release.The attempted fix in #1026 probably didn't help, but this one will basically return things to the route that I originally tested.
I won't be able to retest shiny sound detection, but I can re-check the route once I have some time to roll the correct Hyperspace map.