Xnetevents non x subscription #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishilico
requested changes
Jan 30, 2017
| $full_name = build_full_name($firstname, $lastname); | ||
| $directory_name = build_directory_name($firstname, $lastname); | ||
| $sort_name = build_sort_name($firstname, $lastname); | ||
| XDB::execute('INSERT INTO accounts SET firstname={?}, lastname={?}, full_name={?}, directory_name={?}, sort_name={?}, hruid={?}, email={?}, type={?}, state={?}', $firstname, $lastname, $full_name, $directory_name, $sort_name, $hruid, Get::v('email'), "xnet", "active"); |
Member
There was a problem hiding this comment.
This may break if an hruid already exists for the given email address? User::makeHrid (https://github.com/Polytechnique-org/platal/blob/core/1.1.16/maint/classes/pluser.php#L431) is not injective. For example:
makeHrid("[email protected]") == makeHrid("[email protected]")
A possible solution would be to add a counter when a collision happens
modules/xnetevents.php
Outdated
| XDB::execute('INSERT INTO accounts SET firstname={?}, lastname={?}, hruid={?}, email={?}', Get::v('prenom'), Get::v('nom'), Get::v('prenom').".".Get::v('nom'), Get::v('email')); | ||
|
|
||
| //check if the email address is already registered | ||
| $res=XDB::query("SELECT hruid FROM accounts WHERE email={?}", Get::v('email')); |
Member
There was a problem hiding this comment.
We may want to check the email redirections too
Author
|
À voir :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.