fix: hashtables <1.4.1 fail to build with GCC 15 #4315
Conversation
cabal.project
Outdated
|
|
||
| -- avoid hashtables pre-1.4.1 that fail to build with GCC 15; see https://github.com/gregorycollins/hashtables/issues/98 | ||
| constraints: | ||
| hashtables >= 1.4.1 |
There was a problem hiding this comment.
This line causes rebuilds for Nix, too - which we don't need, because we're not running GCC 15 there, yet.
You can see this in the failing CI jobs:
hashtables-1.4.2 (lib) (requires download & build)
Maybe we should just do something like allow-newer here for it or so. The stack deps are pinned anyway, and Nix could happily use the older version.
There was a problem hiding this comment.
or maybe just remove it altogether from cabal.project? next nixpkgs upgrade will either have 1.4.2 since it's next version in stackage or won't build in case of GCC upgrade only and will be fixed subsequently
There was a problem hiding this comment.
if removal works, then yes.
There was a problem hiding this comment.
done, please review again.
develop7
force-pushed
the
fix-hashtables_gcc_15
branch
2 times, most recently
from
351762d to
cf5e7e2
Compare
Introduces hashtables >= 1.4.1 requirement
develop7
force-pushed
the
fix-hashtables_gcc_15
branch
from
cf5e7e2 to
31ca99c
Compare
|
rebased the PR against latest |
2 participants
Repro:
stack buildExpected: compilation succeds
Instead: build fails building
hashtables-1.3.1, reproducing gregorycollins/hashtables#98This PR makes sure
hashtables' version is >= 1.4.1, one with the issue fixed. Stack.yaml specifies 1.4.2 because it's the next version after in the stackage snapshots: https://github.com/commercialhaskell/stackage-snapshots/blob/master/lts/24/0.yaml#L5300