Skip to content

Conversation

@alagoutte
Copy link
Contributor

Support of partial Forward (need to add StaticRoutes NextHop), Reject and Blackhole

alagoutte added 20 commits April 2, 2020 07:15
for get Static Routes Information (address_family, prefix, static_nexthops, type)
(Don't work for the moment.. get a 500 Error...)
Need to enhance vrf part (for add and remove)
…rameter

more easy for remove after and also display !
…outes

But fail for remove... (need to add Context for VRF...)
and also use better variable for prefix URI (replace / by %2F)
throw "Element specified does not contain a address_family property."
}
if ( -not ( $argument | get-member -name prefix -Membertype Properties)) {
throw "Element specified does not contain an prefix property."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is "a prefix" not "an"

#Check if it looks like an Static Routes element

if ( -not ( $argument | get-member -name address_family -Membertype Properties)) {
throw "Element specified does not contain a address_family property."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is "an address..."


<#
.SYNOPSIS
Add Aruba CX Static Static Route

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static Static ?


End {
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a blank line ?


<#
.SYNOPSIS
Get list of all Aruba CX Route

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

routes*

$sr = Get-ArubaCXStaticRoutes -prefix $pester_sr -vrf $pester_vrf
Confirm-ArubaCXStaticRoutes ($sr) | Should -Be $true
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context isn't close

$sr.type | Should -Not -BeNullOrEmpty
$sr.vrf | Should -Be $pester_vrf
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove blank line

$sr.prefix | Should -Be $pester_sr
$sr.vrf | Should -Be $pester_vrf
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

}
}


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again


Describe "Add Static Route" {


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again ..

[Parameter (Mandatory = $true)]
[object]$argument
)
#Check if it looks like an Static Routes element
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo an => a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants