Update fetch timeouts as a factor of committee size #3139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
reviewed
Mar 1, 2024
ljedrz
reviewed
Mar 1, 2024
Comment on lines
+447
to
+451
| let num_validators = self | ||
| .ledger | ||
| .get_committee_lookback_for_round(self.storage.current_round()) | ||
| .map_or(Committee::<N>::MAX_COMMITTEE_SIZE as u64, |committee| committee.num_members() as u64); | ||
| let timeout_in_ms = max_fetch_timeout_in_ms(num_validators); |
Collaborator
There was a problem hiding this comment.
since this is the next time this is calculated, maybe a dedicated method would be a good idea?
Collaborator
There was a problem hiding this comment.
(I can also see this done in the worker module)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates the
MAX_FETCH_TIMEOUT_IN_MSto a dynamic timeout based on the number of validators in the committee set.The proposed formula for the fetch timeout is
BASE_FETCH_TIMEOUT_IN_MS+Xms per validator in the committee set with a maximum of 30 seconds. ThisXis currently set to 200ms, but can be adjusted based on need.The
BASE_FETCH_TIMEOUT_IN_MSis the originalMAX_FETCH_TIMEOUT_IN_MSfrom before the change, so some example values for timeouts would be:10 validators => 200 * 10 + 7500 = 9500ms
50 validators => 200 * 50 + 7500 = 17500ms
100 validators => 200 * 100 + 7500 = 27500ms
113+ validators => 30000ms
Related PRs
Based on #3135