[devnet] devnet-topo.sh is an alternative to devnet.sh that sets up a… #3675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… different trusted peer graph
kaimast
previously approved these changes
Jun 11, 2025
Contributor
kaimast
left a comment
kaimast
left a comment
There was a problem hiding this comment.
Looks good! I ran the script locally and it seems to work as expected.
devnet-topo.sh
Outdated
| metrics_flag="" | ||
|
|
||
| if [ "$validator_index" -eq 0 ]; then | ||
| # Enable metrics only for the first validator. |
Contributor
There was a problem hiding this comment.
We can enable metrics for all validators, like we do in the devnet.sh script now.
devnet-topo.sh
Outdated
| done | ||
|
|
||
| # Create the list of peers (i.e., trusted peers) for the validator at the_validator_index | ||
| # It is the corresponding client now. |
Contributor
There was a problem hiding this comment.
Do you mean "it is only the corresponding client now"?
…lients per validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up a trusted peers topology that might better reflect mainnet.
Prevents validators from accepting external peer connections.
Otherwise mainly the same as
devnet.sh.