Skip to content

[Fix] Clean up devnet peering and other CI script improvements #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vicsn merged 9 commits into from
Dec 18, 2025
Merged

[Fix] Clean up devnet peering and other CI script improvements #4043

vicsn merged 9 commits into from
Dec 18, 2025

Conversation

@kaimast
Copy link
Contributor

@kaimast kaimast commented Dec 16, 2025 •
edited
Loading

Motivation

I ran into a few more issues with the devnet script while working on #4033. This PR isolates those changes into a separate PR.

Overview of Changes

  • c5c738f reworks how devnet nodes connect to each other. See longer description below.
  • c1280fc ensure that a node failing during devnet setup shuts down the script.
  • 70f7302 fixes all warnings for shellcheck -x .ci/*.sh.
  • 3638c79 adds a CI job that runs shellcheck on all CI scripts. This allows us to catch bugs in the scripts earlier

Devnet Changes

  • Each client now connects to two validators
  • Validators add clients to their trusted peers (requires passing the new --dev-num-clients
  • Most peering code has been removed from devnet_ci.sh

@kaimast kaimast changed the title [Fix] Clean up devnet peering and other devnet script improvements [Fix] Clean up devnet peering and other CI script improvements Dec 16, 2025
@kaimast kaimast marked this pull request as ready for review December 17, 2025 00:34
vicsn
vicsn previously approved these changes Dec 17, 2025
View reviewed changes
Copy link
Collaborator

@vicsn vicsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

@kaimast kaimast requested a review from vicsn December 17, 2025 18:33
@vicsn vicsn merged commit b7a8012 into staging Dec 18, 2025
4 of 5 checks passed
@vicsn vicsn deleted the fix/scripts branch December 18, 2025 02:32
@vicsn
Copy link
Collaborator

vicsn commented Dec 18, 2025

@kaimast sorry I merged too quickly, devnet-workflow failed

@kaimast kaimast mentioned this pull request Dec 18, 2025
Merged
kaimast added a commit that referenced this pull request Dec 18, 2025
@kaimast
Merge pull request #4046 from ProvableHQ/fix/scripts
a51e77b 
[Fix] Follow up for #4043
@kaimast kaimast mentioned this pull request Dec 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicsn vicsn vicsn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaimast @vicsn