Change text input to not internally store text value #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the value used is the value provided, which allows for better control.
The original behavior just caches the value internally, which makes it hard to change the text value from code unless doing something hacky like changing the ID.
This also means that in order to have text inputs work, the developer needs to implement the callback, but this is reasonable and provides better control:
This is a change that I made a while ago in my fork, but didn't make a PR for since it's somewhat of a hacky solution.
I'm opening this now since Zed had the same issue as me in the Discord. I plan to improve on this a bit more in the future (look into alternative way of setting the text value;
maybe make the callback requireddone).