Skip to content

Conversation

@HumphreyYang
Copy link
Member

Hi @jstac, this PR updates the exercises into the discussions, but given @mmcky is working so fast in fixing glue, this PR might longer be necessory : )

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the "Impact of Parameters" section of the McCall model with separation lecture by converting it from a presentation-first format (showing figures upfront) to an exercise-driven discussion format. The change enhances pedagogical value by having students generate and interpret the results themselves rather than viewing pre-made figures.

Key Changes:

  • Removes three glue figure references that showed results before students attempted exercises
  • Splits a single multi-part exercise into three separate, focused exercises (one for each parameter: unemployment compensation, discount factor, and separation rate)
  • Moves interpretive discussion from before the exercises into the solution sections

@github-actions
Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-701--sunny-cactus-210e3e.netlify.app (f59c4bb)

📚 Changed Lecture Pages: mccall_model_with_separation

@github-actions
Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-701--sunny-cactus-210e3e.netlify.app (c8d3e9f)

📚 Changed Lecture Pages: mccall_model_with_separation

@jstac
Copy link
Contributor

jstac commented Nov 14, 2025

Many thanks @HumphreyYang . Much appreciated.

I'll leave this with @mmcky .

@mmcky
Copy link
Contributor

mmcky commented Nov 14, 2025

thanks @HumphreyYang -- appreciate your time putting this together.

Let me know if there are components of this we should keep.

@github-actions
Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-701--sunny-cactus-210e3e.netlify.app (848ba34)

📚 Changed Lecture Pages: mccall_model_with_separation

@HumphreyYang
Copy link
Member Author

Hi @mmcky,

I reverted the exercise changes and did some stylesheet policing. I think it is ready to be merged!

Many thanks!

@HumphreyYang HumphreyYang marked this pull request as ready for review November 15, 2025 02:58
@jstac
Copy link
Contributor

jstac commented Nov 16, 2025

Thanks @HumphreyYang !

@mmcky , what is the policy regarding pip install jax in these lectures?

We need it for the downloads but will it cause trouble with the build? Please let me know as soon as you can.

@HumphreyYang
Copy link
Member Author

HumphreyYang commented Nov 16, 2025

Hi @jstac,

@mmcky and I had an discussion on this before. Installing JAX would not cause issue for the build because pipskip it when it is detected in the system!

Requirement already satisfied: jax in /home/runner/miniconda3/envs/quantecon/lib/python3.13/site-packages (0.8.0)

As long as we don't put -U, it would not reinstall JAX.

@jstac
Copy link
Contributor

jstac commented Nov 16, 2025

Thanks @HumphreyYang .

Is there an open issue to unify treatment of this across the lectures? We want files to execute on download in an anaconda-only setting.

@jstac jstac merged commit d1d868c into main Nov 16, 2025
1 check passed
@jstac jstac deleted the split_mcall_exercise branch November 16, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants