Skip to content

fix: WriteFile error with object content (#535) #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrMYHuang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: WriteFile error with object content (#535) #860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/core/src/tools/tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { ToolErrorType } from './tool-error.js';
import type { DiffUpdateResult } from '../ide/ideContext.js';
import { SchemaValidator } from '../utils/schemaValidator.js';
import { type SubagentStatsSummary } from '../subagents/subagent-statistics.js';
import type { WriteFileToolParams } from './write-file.js';

/**
* Represents a validated and ready-to-execute tool call.
Expand Down Expand Up @@ -274,6 +275,13 @@ export abstract class BaseDeclarativeTool<
TResult extends ToolResult,
> extends DeclarativeTool<TParams, TResult> {
build(params: TParams): ToolInvocation<TParams, TResult> {
// Issue: https://github.com/QwenLM/qwen-code/issues/535
// Workaround issue of some params.content type is object, but their schema type is string.
const writeFileToolParams = params as WriteFileToolParams;
if (writeFileToolParams.content != null && typeof writeFileToolParams.content !== 'string') {
writeFileToolParams.content = JSON.stringify(writeFileToolParams.content);
}

const validationError = this.validateToolParams(params);
if (validationError) {
throw new Error(validationError);
Expand Down