Add RT NaN matching option to ms_target_screening tool #717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--allow_rt_naparameter to thems_target_screeningtool that enables matching based on m/z only when marker retention time (RT) is NaN. This feature is useful for suspect screening of peaks without RT information.Problem
Previously, the tool required both m/z AND RT matches for all markers. When markers had NaN RT values, they were completely excluded from matching, preventing suspect screening scenarios where RT information might be missing or unavailable.
Solution
Added a new boolean parameter
--allow_rt_nathat:Key Features
Example Usage
Test Results
With test data containing 5 markers with NaN RT values:
--allow_rt_na: 24 matches (includes NaN RT markers based on m/z only)This implementation provides the flexibility needed for suspect screening while maintaining the conservative default behavior for routine targeted analysis.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.