[torch][windows] Set hip_device_lib_path on Windows. #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellaraccident
approved these changes
Jul 9, 2025
Collaborator
stellaraccident
left a comment
stellaraccident
left a comment
There was a problem hiding this comment.
Approved with requested change.
| # Obviously, this should be completely burned with fire once the root causes | ||
| # are eliminted. | ||
| hip_device_lib_path = get_rocm_path("root") / "llvm" / "amdgcn" / "bitcode" | ||
| if is_windows: |
Collaborator
There was a problem hiding this comment.
This was an unfortunate typo in the original. You can collapse both of these down to "root"/lib/llvm/amdgcn/bitcode and avoid the platform branch.
Really need to track down the bug that is causing this.
Member
Author
There was a problem hiding this comment.
Thanks, I suspected that we could collapse it but figured the symlink was there for "reasons". At least for code we control we can use the full path that is consistent.
ScottTodd
added a commit
that referenced
this pull request
Jul 10, 2025
Progress on #827 (!!) Tested at https://github.com/ROCm/TheRock/actions/runs/16185309410, which triggered these: * https://github.com/ROCm/TheRock/actions/runs/16186383600 (gfx1151) * https://github.com/ROCm/TheRock/actions/runs/16186941663 (gfx120X-all) * https://github.com/ROCm/TheRock/actions/runs/16186966931 (gfx110X-dgpu) Some next steps after this, roughly in order: * Monitor scheduled jobs to check that wheels are successfully built and uploaded * Download/install and test the wheels on various systems, exercising components like hipBLASLt * Update support status: * https://github.com/ROCm/TheRock?tab=readme-ov-file#support-status * https://github.com/ROCm/TheRock/blob/main/RELEASES.md#python-packages-support-status * Build torchvision and torchaudio (need some patches) * Connect with other build/test/release workflows so we get pre-submit, post-submit, and scheduled coverage for these builds/releases/tests * Rebase patches onto PyTorch 2.8 (and/or HEAD), land patches upstream * Add features like Triton support (aotriton?) for optimized flash attention kernels, etc. * Expand the list of supported gfx targets --- ~~This depends on some other open PRs, but I have tested parts of it all the way through to dev wheel publishing and then installation and testing on a dev machine: https://github.com/ROCm/TheRock/actions/runs/16181411431/job/45678668536, #827 (comment) ~~See the other PRs:~~ * ~~#783 * ~~#980 * ~~#988 * ~~#990
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #827.
Follow-up to #959, expanding support on Windows.
Without this I get a warning from
build_prod_wheels.pyon Windows:Followed by errors late into the build:
Also setting
enventries using an explicitstr()instead of a rawPathsince that led to other errors.