Cherry-pick fused_adam_cuda related patches and add its unit tests to the ROCm extension test script #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IA#1446) Checkpointing can fail since pickle doesn't support >4GB strings by default
* Optimize dist Adam kernels and implementation Add option to directly use params instead of storing main params. Add option to store 16-bit param remainders and reconstruct fp32 main params out of bf16 params. Add option to choose between Adam and AdamW optimizer. Miscellaneous tweaks to simplify code and avoid GPU synchronization. Avoid calling NCCL collectives in side streams. * Use FMAs for lerps in dist Adam kernels Review suggestions from @crcrpar.
This reverts commit 3126ca1.
Author
|
jenkins: retest this please |
2 similar comments
Author
|
jenkins: retest this please |
Author
|
jenkins: retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.