Skip to content

Conversation

@mozga-amd
Copy link
Contributor

Proposed changes

This pull request includes changes that involve: adding the suffix “s” to functions that take more than one input parameter, and adding safeguards to functions that accept tuples.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

Copy link
Collaborator

@aosewski aosewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mozga-amd , thanks for you changes. Still need this one to be added:

  • - change the loading logic of multiple tiles. You can merge current both methods to load tiles and have one which could optionally load a bunch of additional tile windows and run elementwise function on all of them.
  • - Please don't change the semantic of tile loading: if we call load on a tile window object the user expect that that tile window object data are loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants