Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
733 commits
Select commit Hold shift + click to select a range
e56f7a7
Delete FeedlyAccountDelegate+OAuth.swift.
brentsimmons May 2, 2024
8de7b56
Rename OAuthAccountAuthorizationOperation to FeedlyOAuthAccountAuthor…
brentsimmons May 2, 2024
a1c2a2b
Create folders in Account module for each account type.
brentsimmons May 2, 2024
81a6888
Fix concurrency warning.
brentsimmons May 2, 2024
f3e8d53
Fix some concurrency warnings.
brentsimmons May 2, 2024
9f97b08
Fix concurrency warning for OSLog.
brentsimmons May 2, 2024
e9ba295
Fix concurrency warning.
brentsimmons May 2, 2024
51b78dd
Fix concurrency warning.
brentsimmons May 2, 2024
325f806
Fix a few concurrency warnings.
brentsimmons May 3, 2024
5c31993
Fix concurrency warning.
brentsimmons May 3, 2024
6c1ea42
Fix concurrency warnings about gPingPongMap.
brentsimmons May 3, 2024
6776862
Fix concurrency warnings in ShareViewController.
brentsimmons May 3, 2024
81cede7
Fix a few concurrency warnings.
brentsimmons May 3, 2024
19fd3d9
Fix a few concurrency warnings.
brentsimmons May 3, 2024
02d8005
Fix a couple concurrency warnings.
brentsimmons May 3, 2024
a9d50f3
Make some things private in UserApp.
brentsimmons May 4, 2024
2418076
Fix some concurrency warnings.
brentsimmons May 4, 2024
18d0b0e
Fix concurrency warning in SendToCommand.
brentsimmons May 4, 2024
78a64c3
Make WebViewController fina.
brentsimmons May 4, 2024
9403d81
Fix concurrency warning.
brentsimmons May 4, 2024
0a2b4f7
Silence concurrency warning.
brentsimmons May 4, 2024
07091e0
Fix concurrency warning.
brentsimmons May 4, 2024
09cf212
Fix some concurrency warnings.
brentsimmons May 4, 2024
22d184c
Fix concurrency warning.
brentsimmons May 4, 2024
9dcfc2b
Fix concurrency warning.
brentsimmons May 4, 2024
87fe78f
Fix concurrency warning.
brentsimmons May 4, 2024
7d04021
Fix some concurrency warnings.
brentsimmons May 4, 2024
fdbcf0d
Fix concurrency warning.
brentsimmons May 4, 2024
ea0a827
Fix some concurrency warnings.
brentsimmons May 4, 2024
4ea66ee
Fix some concurrency warnings.
brentsimmons May 4, 2024
db9a8c7
Fix some concurrency warnings.
brentsimmons May 4, 2024
7f545c5
Fix some concurrency warnings.
brentsimmons May 4, 2024
8329877
Fix concurrency warning.
brentsimmons May 4, 2024
1e80253
Fix some concurrency warnings.
brentsimmons May 4, 2024
3f8724c
Silence concurrency warning.
brentsimmons May 4, 2024
19a39ac
Make TimelineTitleView final.
brentsimmons May 4, 2024
7f042b5
Fix concurrency warning.
brentsimmons May 4, 2024
16cebcd
Fix some concurrency warnings.
brentsimmons May 4, 2024
bf02d1d
Use targeted concurrency for the app. Remaining concurrency warnings …
brentsimmons May 4, 2024
30e961b
Fix warning about unused @preconcurrency.
brentsimmons May 4, 2024
178cba3
Turn on strict concurrency for Mac targets.
brentsimmons May 5, 2024
4b381da
Convert restoreWindow to async await.
brentsimmons May 5, 2024
c96a3c7
Rename completion to callback, since it wasn’t a completion handler.
brentsimmons May 5, 2024
399703c
Rename completion to callback, since it wasn’t a completion handler.
brentsimmons May 5, 2024
fba8c52
Convert several methods to async await.
brentsimmons May 6, 2024
cd7f4f7
Convert runSheetOnWindow to async.
brentsimmons May 6, 2024
3d91a6b
Convert some functions to async instead of completion-based.
brentsimmons May 6, 2024
c46494d
Use async await in runSheetOnWindow.
brentsimmons May 6, 2024
b4c8a69
Convert method to async.
brentsimmons May 6, 2024
bfa7ad5
Make SceneDelegate final.
brentsimmons May 6, 2024
18acf59
Move maxY extension method to FoundationExtras.
brentsimmons May 7, 2024
a80acba
Add missing import.
brentsimmons May 7, 2024
7308cb6
Move Bundle extension to the place where it’s used.
brentsimmons May 7, 2024
314da23
Move some String extensions to UIKitExtras.
brentsimmons May 7, 2024
e84d8ad
Move TickMarkSlider to UIKitExtras.
brentsimmons May 7, 2024
043b784
Move RoundedProgressView to UIKitExtras.
brentsimmons May 7, 2024
51a893e
Move Animations and UITableView extensions to UIKitExtras.
brentsimmons May 7, 2024
03eff6a
Move UIPageViewController extension to the file where it’s used.
brentsimmons May 7, 2024
482ff49
Move UIFont extension to the file where it’s used.
brentsimmons May 7, 2024
ae2c21f
Move NonIntrinsic* views to UIKitExtras.
brentsimmons May 7, 2024
69c908c
Convert UserAgent functions to variables and make them non-optional.
brentsimmons May 8, 2024
1381778
Fix build error.
brentsimmons May 8, 2024
ae77aec
Make DatabaseIDCache properly Sendable (instead of unchecked) by usin…
brentsimmons May 8, 2024
48bfced
Simplify and improve DatabaseIDCache.
brentsimmons May 9, 2024
a315118
Add and use MimeType.formURLEncoded.
brentsimmons May 9, 2024
be45647
Convert NewsBlurAPICaller to async await.
brentsimmons May 9, 2024
d58821a
Convert NewsBlur to async await.
brentsimmons May 14, 2024
a474a8f
Make insertStatuses take a Set.
brentsimmons May 14, 2024
ab4d51b
Make SyncDatabase.resetSelectedForProcessing and .deleteSelectedForPr…
brentsimmons May 15, 2024
01f08b9
Make FeedlyOAuthAccountAuthorizationOperation not a MainThreadOperati…
brentsimmons May 15, 2024
ec12232
Move MainThreadOperation and MainThreadOperationQueue to CloudKitSync…
brentsimmons May 15, 2024
aa14143
Delete unused FeedlyCheckpointOperationTests (since FeedlyCheckpointO…
brentsimmons May 16, 2024
a3dda4c
Move FeedlyCollectionParserTests to the Feedly module. (It passes.)
brentsimmons May 16, 2024
7f6112d
Delete unused FeedlyOperationTests.
brentsimmons May 16, 2024
66e169d
Move FeedlyTextSanitizationTests to Feedly module.
brentsimmons May 16, 2024
6adbc82
Delete unused FeedlyTestSecrets.
brentsimmons May 16, 2024
c75f3a8
Move FeedlyResourceIDTests to Feedly module.
brentsimmons May 16, 2024
efe413b
Move FeedlyFeedParserTests to Feedly module.
brentsimmons May 16, 2024
544dcf6
Move FeedlyEntryParserTests to Feedly module.
brentsimmons May 16, 2024
5760705
Rename FeedlyOrganiseParsedItemsByFeedOperationTests to ParsedItemsKe…
brentsimmons May 18, 2024
d024e60
Create FeedlyUtilities and FeedlyUtilitiesTests.
brentsimmons May 18, 2024
a579126
Use FeedlyUtilities in FeedlyAccountDelegate.
brentsimmons May 18, 2024
45c08cd
Delete no-longer-used function.
brentsimmons May 18, 2024
d962fc5
Delete unused test.
brentsimmons May 18, 2024
c491fd2
Remove unneeded extension breaks.
brentsimmons May 18, 2024
16ed322
Delete unused test.
brentsimmons May 18, 2024
2ed93e4
Make TestAccountManager final.
brentsimmons May 18, 2024
0cf78a3
Create ArrayExtensionsTests.
brentsimmons May 18, 2024
ff1caf4
Remove unused function.
brentsimmons May 18, 2024
9c6d91e
Add to ArrayExtensionsTests.
brentsimmons May 18, 2024
5ec78cb
Rename to Calendar+Extensions.swift.
brentsimmons May 18, 2024
0ec83de
Write CalendarExtensionsTests.
brentsimmons May 18, 2024
22d9b31
Simplify isDarkMode.
brentsimmons May 18, 2024
b601cc1
Create NetNewsWire.xctestplan and add it to the NetNewsWire and NetNe…
brentsimmons May 18, 2024
756231c
Create AppKitExtras tests. Add it to test plan. Add parser tests to t…
brentsimmons May 19, 2024
72ba127
Fix ParserTests.
brentsimmons May 19, 2024
fcfe843
Turn off code coverage because it was making the build fail.
brentsimmons May 19, 2024
cea9773
Add TreeTests.
brentsimmons May 19, 2024
0ca7f7b
Delete unused Blocks.swift.
brentsimmons May 19, 2024
46b9eba
Create Tree and TreeTests schemes. Rename App.xctestplan to Mac.xctes…
brentsimmons May 20, 2024
fe1faac
Remove Mac.xctestplan from iOS app scheme.
brentsimmons May 20, 2024
7efd004
Add iOS test plan.
brentsimmons May 21, 2024
6176f31
Recreate Mac.xctestplan, since Xcode started treating it as plain text.
brentsimmons May 21, 2024
01e3782
Start CoreTests and add to test plans.
brentsimmons May 21, 2024
ad61c01
Delete unused code in Web module.
brentsimmons May 21, 2024
72e83be
Add first Web test. Add WebTests to test plans.
brentsimmons May 21, 2024
4a173c9
Fix warning in Feedly tests.
brentsimmons May 22, 2024
c35008b
Add FeedlyTests to test plans.
brentsimmons May 22, 2024
d52b524
Comment-out non-functional Account tests. Add Account tests to test p…
brentsimmons May 22, 2024
1c1cd27
Add NetNewsWire-iOSTests to test plan.
brentsimmons May 22, 2024
6df9d1a
Merge
brentsimmons May 22, 2024
1fee1f5
Fix conflicts in test plan files.
brentsimmons May 22, 2024
926b8f4
Make ParserObjC a separate package and fix some linking issues.
brentsimmons May 22, 2024
da8b2c3
Fix some link issues.
brentsimmons May 22, 2024
43a9479
Fix the last of the duplicate implementation warnings.
brentsimmons May 22, 2024
4323c24
Convert delete to async await.
brentsimmons May 22, 2024
391408f
Make DownloadSession use String identifier instead of AnyObject.
brentsimmons May 26, 2024
fb5a1b2
Make DownloadSession use String identifier instead of AnyObject.
brentsimmons May 26, 2024
ea3a78b
Create FeedDownloader local package.
brentsimmons May 26, 2024
33215ba
Update LocalAccountDelegate to use new FeedDownloader package. Tempor…
brentsimmons May 26, 2024
4010504
Rename `isNotifyAboutNewArticles` to `shouldSendUserNotificationForNe…
brentsimmons May 26, 2024
e275367
Provide hash(into:) functions where the default implementation might …
brentsimmons May 26, 2024
666f1d9
Remove unused code in Keyboard.swift. Make the String extension priva…
brentsimmons May 26, 2024
b5d1327
Use a Set rather than an O(n) thing to unique DatabaseObjects.
brentsimmons May 26, 2024
b0263c4
Add some logging to LocalAccountDelegate.
brentsimmons May 26, 2024
83840bd
Add User-Agent header.
brentsimmons May 27, 2024
0ab4eac
Remove code that sets User-Agent header — because it’s already set fo…
brentsimmons May 27, 2024
ede43bb
Fix a few bugs.
brentsimmons May 27, 2024
9864bd5
Call downloadProgress.clear().
brentsimmons May 27, 2024
545ed4a
Make find-feed window regular instead of HUD.
brentsimmons May 27, 2024
9d747a9
Make add-feed work again.
brentsimmons May 27, 2024
58ba14c
Add logging to FeedFinder.
brentsimmons May 28, 2024
08a80cd
Create `ArticleSupport` struct for `CloudKitArticlesZoneDelegate` to …
brentsimmons Jun 3, 2024
f7201ee
Move `CloudKitArticlesZoneDelegate` to CloudKitSync module.
brentsimmons Jun 3, 2024
ef43773
Remove no-longer-used support for dependencies in MainThreadOperation.
brentsimmons Jun 3, 2024
ea661fb
Remove some unused code.
brentsimmons Jun 5, 2024
9940985
Create Account > AccountDelegates folder and put all the AccountDeleg…
brentsimmons Jun 5, 2024
ee8fa01
Move `FeedlyOAuthAccountAuthorizationOperation` into `FeedlyAccountDe…
brentsimmons Jun 5, 2024
3df22da
Move NewsBlur internal to NewsBlurAccountDelegate, so that each accou…
brentsimmons Jun 5, 2024
3a992d4
Convert downloader to async await. Convert FeedFinder to async await.
brentsimmons Jun 8, 2024
971f49a
Delete no longer needed Scanner+Extensions.
brentsimmons Jun 8, 2024
cdc62c2
Remove superfluous MainActor annotations.
brentsimmons Jun 8, 2024
f872f8a
Turn on strict concurrency.
brentsimmons Jun 8, 2024
fe49f3b
Remove numerous superfluous MainActor annotations.
brentsimmons Jun 8, 2024
4ec5990
Check if suspended in a couple additional places.
brentsimmons Jun 8, 2024
447aa7a
Empty more caches — reclaim more memory — on app resigning active.
brentsimmons Jun 8, 2024
e74c815
Remove no-longer-needed Unicode support for URL (since it’s part of i…
brentsimmons Jun 9, 2024
9c23b13
Create and use DataFile class. Start getting away from CoalescingQueu…
brentsimmons Jun 9, 2024
0d36fac
Remove unused saveQueue.
brentsimmons Jun 9, 2024
74a42c6
Create and use PostponingBlock.
brentsimmons Jun 10, 2024
3e53dfb
Make SmartFeed MainActor.
brentsimmons Jun 10, 2024
5d066e5
Add name parameter to PostponingBlock. Add notification appUnreadCoun…
brentsimmons Jun 10, 2024
a8f952b
Use Logger with OPMLFile.
brentsimmons Jun 10, 2024
96fefbc
Add logging to PostponingBlock.
brentsimmons Jun 10, 2024
c1f6026
Rename Account.type to Account.accountType.
brentsimmons Jun 10, 2024
7fe5f94
Remove unused AddFeedType.
brentsimmons Jun 11, 2024
9317874
Fix performance issue on launch — ignore structure changes while load…
brentsimmons Jun 11, 2024
0c923a9
Fix bug fetching unread count for single feed.
brentsimmons Jun 13, 2024
9509956
Make block a MainActor block.
brentsimmons Jun 13, 2024
5739983
Add queueUpdateDockBadge. Use PostponingBlock instead of CoalescingQu…
brentsimmons Jun 13, 2024
a91fd53
Reorder arguments to PostponingBlock.init.
brentsimmons Jun 13, 2024
d9f2607
Capture self weakly in PostponingBlock.
brentsimmons Jun 13, 2024
57ac2d6
Use weak self in postponingBlock.
brentsimmons Jun 13, 2024
7dc0d6c
Use queueMakeToolbarValidate.
brentsimmons Jun 13, 2024
308a91c
Go back to CoalescingQueue because it was simpler to use than Postpon…
brentsimmons Jun 13, 2024
9b9d33f
Make FeedMetadataFile use DataFile.
brentsimmons Jun 13, 2024
f8f67b1
Make AccountMetadataFile use DataFile.
brentsimmons Jun 13, 2024
5a02ba4
Use Task.sleep instead of a weird thing.
brentsimmons Jun 13, 2024
9227924
Add logging to DataFile.
brentsimmons Jun 15, 2024
64fc186
Get rid of maxInterval from CoalescingQueue because it didn’t actuall…
brentsimmons Jun 16, 2024
4692134
Log in CoalescingQueue only when a local `debugging` property is true
brentsimmons Jun 18, 2024
0764420
Make Feedbin syncing fetch articles.
brentsimmons Jun 18, 2024
a07daed
Fix crash when feedIDs.count < 1
brentsimmons Jun 20, 2024
8cf880b
Fix module name for RoundedProgressView.
brentsimmons Jun 20, 2024
d94f8a5
Use renamed class names.
brentsimmons Jun 20, 2024
16b2e55
Rename debugging property to loggingEnabled, since it really just con…
brentsimmons Jun 20, 2024
9a26df8
Fix bug where sidebar unread count view would flicker as the timeline…
brentsimmons Jun 22, 2024
b264305
Fix bug saving authors in database.
brentsimmons Jun 23, 2024
89e16f5
Make webView optional.
brentsimmons Jun 27, 2024
aaf8268
Create AppConfig module and AppLocations.
brentsimmons Jun 27, 2024
840147a
Use AppConfig in Images module.
brentsimmons Jun 27, 2024
8cd69d7
Create .shared of FaviconDownloader, AuthorAvatarDownloader, FeedIcon…
brentsimmons Jun 27, 2024
00f3b42
Add support appUnreadCountDidChange Notification.
brentsimmons Jun 27, 2024
4513986
Use .appUnreadCountDidChange notification solely to get unread count.
brentsimmons Jun 27, 2024
cd0dd24
Refer to AuthorAvatarDownloader.shared.
brentsimmons Jun 27, 2024
6eea4c3
Refer to FaviconDownloader.shared.
brentsimmons Jun 27, 2024
5deae9b
Add AppConfig module to project file.
brentsimmons Jun 27, 2024
ed5a11b
Refer to .shared image downloaders.
brentsimmons Jun 27, 2024
83edb62
Drop local properties and folder calculations for image downloaders.
brentsimmons Jun 27, 2024
b3e6a65
Add feedIconsFolder location.
brentsimmons Jun 27, 2024
47fb0be
Make FeedIconDownloader.shared work.
brentsimmons Jun 27, 2024
a3ff92e
Delete code that is now in AppLocations.
brentsimmons Jun 27, 2024
0ea46e4
Drop properties for image downloaders that are now .shared.
brentsimmons Jun 27, 2024
16ab4b5
Fix bug where Newsblur feeds don't update
quad Jun 27, 2024
a358388
Move AppConfig to Core and delete the AppConfig module.
brentsimmons Jul 1, 2024
7bc980c
Use AppConfig.appName.
brentsimmons Jul 1, 2024
b403a00
Use AppConfig to get folder URL.
brentsimmons Jul 1, 2024
d712199
Remove AppConfig module.
brentsimmons Jul 1, 2024
788cdc6
Remove global appDelegate variable from Mac.
brentsimmons Jul 1, 2024
512aee6
Delete AppConfig.
brentsimmons Jul 1, 2024
e990b7a
Get the app delegate the old-fashioned way.
brentsimmons Jul 1, 2024
ada9818
Create and use shared initializeDownloaders AppDelegate function.
brentsimmons Jul 1, 2024
750e287
Use ImageDownloader.shared.
brentsimmons Jul 1, 2024
caa5f8b
Use initializeDownloaders function.
brentsimmons Jul 1, 2024
f7cd359
Fix a couple concurrency warnings.
brentsimmons Jul 1, 2024
5e64b6a
Merge pull request #4277 from quad/patch-1
brentsimmons Jul 1, 2024
36982ad
Add URLScheme constants to Web module.
brentsimmons Jul 2, 2024
cc71152
Fix URLScheme — make members static.
brentsimmons Jul 2, 2024
79c2f4c
Fix several concurrency warnings.
brentsimmons Jul 2, 2024
09cadf7
Create handleUnreadCountDidChange as shared AppDelegate code.
brentsimmons Jul 3, 2024
364da4e
Add AppConfig.dataFolder.
brentsimmons Jul 3, 2024
0e674d6
Force try in dataFolder — if we can’t get the dataFolder, we need to …
brentsimmons Jul 3, 2024
b71c957
Make DownloadProgress and CombinedRefreshProgress Sendable.
brentsimmons Jul 4, 2024
7bc0465
Make HTTPConditionalGetInfo Sendable.
brentsimmons Jul 6, 2024
88ea5d6
Remove unneeded @MainActor notations.
brentsimmons Jul 6, 2024
ad3035c
Add AppConfig.dataSubfolder method.
brentsimmons Jul 7, 2024
7beb818
Make ArticleThemesManager specify its folder itself.
brentsimmons Jul 7, 2024
85d977f
Fix build errors related to ArticleThemesManager changes.
brentsimmons Jul 7, 2024
fc6d437
Move AppDelegate+Shared to top of its group.
brentsimmons Jul 7, 2024
14bcef0
Make ReaderAPI module not dynamic.
brentsimmons Jul 7, 2024
d50b581
Move local modules into a folder named Modules.
brentsimmons Jul 7, 2024
f3c9cb9
Delete unused FeaturePlanning outline.
brentsimmons Jul 7, 2024
5b4cf23
Delete unused Multiplatform folder.
brentsimmons Jul 7, 2024
90311f0
Make Secrets Sendable. Rename Id to ID.
brentsimmons Jul 7, 2024
329fd5d
Fix iOS build error with renamed Secrets string.
brentsimmons Jul 7, 2024
308c612
Remove unused Frameworks folder.
brentsimmons Jul 7, 2024
6c9f9e2
Add new SecretKey file to .gitignore.
brentsimmons Jul 7, 2024
7d40924
Add SecretKey.swift.gyb to Secrets module.
brentsimmons Jul 7, 2024
445306e
Get rid of SecretsProvider protocol. Stop passing secretsProvider aro…
brentsimmons Jul 7, 2024
aa80724
Make ArticleExtractor reference SecretKey instead of passing in secre…
brentsimmons Jul 7, 2024
c784569
Make AccountManager init itself, and use AccountManager.shared in App…
brentsimmons Jul 7, 2024
44a9a52
Make AccountManager.shared actually call init.
brentsimmons Jul 7, 2024
89a9671
Create importFeedsIfNeeded shared AppDelegate method.
brentsimmons Jul 7, 2024
ba44b94
Create AppAsset shared class, which will replace the separate Mac and…
brentsimmons Jul 8, 2024
030d101
Continue moving from AppAssets to AppAsset.
brentsimmons Jul 10, 2024
de228c6
Delete unused LegacyArticleExtractorButton.swift.
brentsimmons Jul 10, 2024
1660d77
Fix build errors.
brentsimmons Jul 10, 2024
5506f00
Fix property name
plrichardson Jul 19, 2024
a8e9e26
ignore inactive accounts
plrichardson Jul 19, 2024
440a7fb
Continue moving to structured and shared AppAsset over separate AppAs…
brentsimmons Jul 26, 2024
094a85b
Merge pull request #4244 from winniequinn/main
brentsimmons Jul 27, 2024
865d32f
Fix starColor name.
brentsimmons Aug 6, 2024
82fef8c
Merge branch 'main' of https://github.com/Ranchero-Software/NetNewsWire
brentsimmons Aug 6, 2024
65a1812
Remove MainActor annotation from FeedFinder — it’s not needed.
brentsimmons Aug 6, 2024
090c8e0
Bring extra-milliseconds fix to main
zll600 Aug 25, 2024
b6c5d84
Mention .xcodeproj in readme instead .xcworkspace
ankushkushwaha Sep 6, 2024
ad0dcf3
Merge pull request #4357 from ankushkushwaha/fix/typo-in-readme
brentsimmons Sep 9, 2024
fc36c5e
Merge pull request #4356 from zll600/bring_extra-milliseconds_fix_to_…
brentsimmons Sep 10, 2024
933211b
Merge pull request #4284 from plrichardson/patch-1
brentsimmons Sep 10, 2024
51b2b5e
Correct ID
lolindrath Sep 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,5 @@ fastlane/test_output
/Shared/Secrets.swift
/Frameworks/Secrets/Secrets.swift
Secrets/Sources/Secrets/Secrets.swift
Modules/Secrets/Sources/Secrets/SecretKey.swift
*.py[cod]
43 changes: 0 additions & 43 deletions Account/Package.swift

This file was deleted.

Loading