Update docs with new features #38

edtoken · 2020-01-24T22:13:37Z

Checks:

Have you checked the dependencies list?
Have you checked the examples page?
Have you checked the build command?
Have you checked with the default environment configuration?

Description

Changes

Update configuration add changelog link
Replace bankAccount with bban
Add organizationId configuration property
Add bic and bankName details
Add changelog content

…ce bankAccount with bban

…Add bic and bankName, docs text cleanup

edtoken · 2020-01-24T22:16:26Z

A few screens with some parts of updates

rensftw · 2020-02-12T16:55:10Z

docs/.vuepress/public/examples/example-locale-1/index.js

    Rebilly.initialize({
        publishableKey: 'pk_sandbox_1234567890',
-        locale: Rebilly.locales.es,
+        locale: 'es-ES',


This looks good 👌 but it depends on the i18n refactoring in FramePay, which is not released yet (see internal FramePay PR #203).
If this gets merged, the docs will not be working properly anymore - perhaps we should consider shipping this update separately, once there are no blockers.

(There's a few different places doing this in the PR)

docs/changelog.md

rensftw · 2020-02-12T17:03:00Z

docs/changelog.md

+
+## 91 (2020-01-20)
+### Added
+- `bic` and `bankName` element types for `Rebilly.bban` and `Rebilly.iban` namespace  


Suggested change

- `bic` and `bankName` element types for `Rebilly.bban` and `Rebilly.iban` namespace

- `bic` and `bankName` element types for the `Rebilly.bban` and `Rebilly.iban` namespaces.

rensftw · 2020-02-12T17:03:20Z

docs/changelog.md

+## 91 (2020-01-20)
+### Added
+- `bic` and `bankName` element types for `Rebilly.bban` and `Rebilly.iban` namespace  
+see [Rebilly.bban.mount](./reference/rebilly.md#rebilly-bban-mount) and [Rebilly.iban.mount](./reference/rebilly.md#rebilly-iban-mount)


Suggested change

see [Rebilly.bban.mount](./reference/rebilly.md#rebilly-bban-mount) and [Rebilly.iban.mount](./reference/rebilly.md#rebilly-iban-mount)

See [Rebilly.bban.mount](./reference/rebilly.md#rebilly-bban-mount) and [Rebilly.iban.mount](./reference/rebilly.md#rebilly-iban-mount).

rensftw · 2020-02-12T17:04:46Z

docs/changelog.md

+## 90 (2020-01-14)
+### Deprecated
+- `Rebilly.bankAccount` namespace.
+The namespace `Rebilly.bankAccount` deprecated but still works, this namespace moved to `Rebilly.bban` namespace with changes of element type names. 


Suggested change

The namespace `Rebilly.bankAccount` deprecated but still works, this namespace moved to `Rebilly.bban` namespace with changes of element type names.

The namespace `Rebilly.bankAccount` is now deprecated, but it currently still works. This namespace is now moved to the `Rebilly.bban` namespace and there are changes to the names of element type.

rensftw · 2020-02-12T17:11:38Z

docs/configuration/README.md

 {
-    publishableKey:'',
+    publishableKey: 'String, required',
+    organizationId: 'String, no-required',


Suggested change

organizationId: 'String, no-required',

organizationId: 'String, optional',

rensftw · 2020-02-12T17:13:19Z

docs/changelog.md

+
+## 92 (2020-01-24)
+### Added
+- `organizationId` configuration property (String, no-required) see [configuration.organizationId](./configuration/properties.md#organizationid)


Suggested change

- `organizationId` configuration property (String, no-required) see [configuration.organizationId](./configuration/properties.md#organizationid)

- `organizationId` configuration property (String, optional). See [configuration.organizationId](./configuration/properties.md#organizationid).

rensftw · 2020-02-12T17:14:13Z

docs/configuration/properties.md

 <<< @/docs/.vuepress/public/examples/example-publishablekey-1/index.js

+## organizationId
+Your organization identifier in scope of which need to perform request (if not specified, the default organization will be used).


Suggested change

Your organization identifier in scope of which need to perform request (if not specified, the default organization will be used).

Your organization identifier, in the scope of which requests are performed. (If it is not specified, the default organization will be used).

rensftw · 2020-02-12T17:16:37Z

docs/reference/data-rebilly-fields.md

+- `emails`
+
+---
+Only for the [BBAN](./rebilly.md#rebilly-bban-mount) and [IBAN](./rebilly.md#rebilly-iban-mount) methods we support additional fields `bic` and `bankName` that can be automatically gathered by FramePay if they are present within the form with a `data-rebilly` attribute:


Suggested change

Only for the [BBAN](./rebilly.md#rebilly-bban-mount) and [IBAN](./rebilly.md#rebilly-iban-mount) methods we support additional fields `bic` and `bankName` that can be automatically gathered by FramePay if they are present within the form with a `data-rebilly` attribute:

Exclusively for the [BBAN](./rebilly.md#rebilly-bban-mount) and [IBAN](./rebilly.md#rebilly-iban-mount) methods we support the additional fields `bic` and `bankName`, which can be automatically gathered by FramePay if they are present within the form with a `data-rebilly` attribute:

rensftw · 2020-02-12T17:16:55Z

docs/reference/data-rebilly-fields.md

+
+---
+
+For example, to collect the `firstName` and `lastName` when the token is created you can setup your form as follows:


Suggested change

For example, to collect the `firstName` and `lastName` when the token is created you can setup your form as follows:

For example, to collect the `firstName` and `lastName` when the token is created, you can setup your form as follows:

Co-Authored-By: Irena Angelova <[email protected]>

edtoken added 6 commits January 25, 2020 01:08

Update configuration add changelog link

9575100

Update examples replace bankAccount with bban

ce381a0

Update configuration documentation, Add organizationId details, repla…

b00393c

…ce bankAccount with bban

Update examples documentation replace bankAccount with bban

fd673c1

Update docs, replace bankAccount with bban, Update data-rebilly docs …

e29d62f

…Add bic and bankName, docs text cleanup

Add changelog content

4e90081

rensftw and others added 6 commits February 5, 2020 13:45

Fix BBAN demo

0817210

Update examples locale usage

a423c8d

Add big iframe size classname

177d1ef

Update configuration locale documentation

1470496

Update usage of locale value

e6b78f7

packages update

42fa699

edtoken requested a review from a team February 10, 2020 13:00

edtoken added the enhancement New feature or request label Feb 10, 2020

edtoken self-assigned this Feb 10, 2020

edtoken marked this pull request as ready for review February 10, 2020 13:00

rensftw reviewed Feb 12, 2020

View reviewed changes

Update docs/changelog.md

c8035d6

Co-Authored-By: Irena Angelova <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update docs with new features #38

Update docs with new features #38

Uh oh!

edtoken commented Jan 24, 2020

Uh oh!

edtoken commented Jan 24, 2020

Uh oh!

rensftw Feb 12, 2020 •

edited

Loading

Uh oh!

rensftw Feb 12, 2020

Uh oh!

Uh oh!

rensftw Feb 12, 2020

Uh oh!

rensftw Feb 12, 2020

Uh oh!

rensftw Feb 12, 2020

Uh oh!

rensftw Feb 12, 2020

Uh oh!

rensftw Feb 12, 2020

Uh oh!

rensftw Feb 12, 2020

Uh oh!

rensftw Feb 12, 2020

Uh oh!

rensftw Feb 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	- `bic` and `bankName` element types for `Rebilly.bban` and `Rebilly.iban` namespace
	- `bic` and `bankName` element types for the `Rebilly.bban` and `Rebilly.iban` namespaces.

	see [Rebilly.bban.mount](./reference/rebilly.md#rebilly-bban-mount) and [Rebilly.iban.mount](./reference/rebilly.md#rebilly-iban-mount)
	See [Rebilly.bban.mount](./reference/rebilly.md#rebilly-bban-mount) and [Rebilly.iban.mount](./reference/rebilly.md#rebilly-iban-mount).

	The namespace `Rebilly.bankAccount` deprecated but still works, this namespace moved to `Rebilly.bban` namespace with changes of element type names.
	The namespace `Rebilly.bankAccount` is now deprecated, but it currently still works. This namespace is now moved to the `Rebilly.bban` namespace and there are changes to the names of element type.

	organizationId: 'String, no-required',
	organizationId: 'String, optional',

	- `organizationId` configuration property (String, no-required) see [configuration.organizationId](./configuration/properties.md#organizationid)
	- `organizationId` configuration property (String, optional). See [configuration.organizationId](./configuration/properties.md#organizationid).

	Your organization identifier in scope of which need to perform request (if not specified, the default organization will be used).
	Your organization identifier, in the scope of which requests are performed. (If it is not specified, the default organization will be used).

	Only for the [BBAN](./rebilly.md#rebilly-bban-mount) and [IBAN](./rebilly.md#rebilly-iban-mount) methods we support additional fields `bic` and `bankName` that can be automatically gathered by FramePay if they are present within the form with a `data-rebilly` attribute:
	Exclusively for the [BBAN](./rebilly.md#rebilly-bban-mount) and [IBAN](./rebilly.md#rebilly-iban-mount) methods we support the additional fields `bic` and `bankName`, which can be automatically gathered by FramePay if they are present within the form with a `data-rebilly` attribute:


		---

		For example, to collect the `firstName` and `lastName` when the token is created you can setup your form as follows:

Update docs with new features #38

Are you sure you want to change the base?

Update docs with new features #38

Uh oh!

Conversation

edtoken commented Jan 24, 2020

Checks:

Description

Changes

Uh oh!

edtoken commented Jan 24, 2020

Uh oh!

rensftw Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rensftw Feb 12, 2020 •

edited

Loading