Skip to content

Conversation

@bsquizz
Copy link
Contributor

@bsquizz bsquizz commented Apr 8, 2025

We ran into an issue where an app team had two bucket configurations for s3 object storage, similar to this:

my-secret-temp
my-secret

The requested bucket name was my-secret, but they were provided the credentials of my-secret-temp.

I'm not aware of a need to use strings.Prefix when searching for the bucket name, so we can instead just do a simple == comparison.

@gburges
Copy link
Contributor

gburges commented Apr 10, 2025

This is good, but can potentially break every/any service that relies on partial match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants