-
Notifications
You must be signed in to change notification settings - Fork 91
3.x #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ManukMinasyan
wants to merge
179
commits into
main
Choose a base branch
from
3.x
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
3.x #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add comprehensive data import system for crm migration: - import center page with quick import, history, and migration wizard tabs - excel to csv conversion via phpspreadsheet - importers for companies, people, opportunities, tasks, and notes - duplicate handling strategy with user choice (skip/update/create) - custom fields integration via weakmap storage - migration batch tracking for multi-entity imports - dependency enforcement (companies before people, etc) - failed rows download for error recovery
- redesign entity cards with cleaner hover states and visual hierarchy - simplify import tips section with minimal bullet styling - improve step progress indicator with connecting lines - refine entity selection cards with subtle borders and transitions - add collapsible progress section in migration wizard step 2 - update completion step with success icon and cleaner summary - add pointer-events-none to icon containers to prevent click issues
- conditionally show logo only on guest pages (login/register/forgot) - fix svg overflow in logo container causing invisible clickable area - change sidebar nav overflow from visible to hidden
- keep brandName for page title display - use empty logo view for authenticated pages - show full logo only on guest pages
- only mark as stuck if processing actually started then stopped - show pending when processed_rows is 0 regardless of total_rows - update test to expect pending for old unprocessed imports
remove MigrationBatch model, factory, migration and migration_batch_id column as they provided no user-facing value - batch data was tracked but never displayed clean up MigrationWizard by removing unused methods (recordImportComplete, getRecentImports) and batch-related code while preserving wizard functionality simplify ImportCenter by removing dead getImportAction and getHeaderActions methods, and simplify hasImportJobFailed from 4 complex queries to 1 remove 9 batch-related tests that no longer apply, update remaining tests
- extract HasImportEntities trait for shared entity configuration - fix PeopleImporter to respect duplicate handling strategy - remove unused CreationSource import from BaseImporter - delete unused column_mappings/duplicate_strategy migration - simplify MigrationWizard with collect() helpers - remove redundant getEntityTypes() alias method
…nd enhancing readability
…in import preview
Feature/import wizard error filter
Track unique new company names during import preview processing. Shows count of companies that will be created when importing People/Opportunities with company references. - Add newCompanies property to ImportSessionData - Accumulate unique new company names across chunks - Display new companies count in preview stats area - Remove per-row match badges (simplify UI)
…ning - Fix bug: enrichRowWithCompanyMatch was reading $row['id'] (person/opportunity ID) instead of $row['company_id'] (actual company ID) - Add hasMappingWarnings() to detect multiple warning conditions - Add hasCompanyNameWithoutId() to detect company_name without company_id mapping - Add getMappingWarningsHtml() to generate dynamic modal content - Extend existing warning modal to show both unique identifier and company warnings
Improvements
add intelligent date format detection that analyzes csv values to determine whether dates are iso, european (dd/mm), or american (mm/dd) format based on unambiguous evidence (values where day > 12). - add DateFormat and TimestampFormat enums with parsing support - add DateFormatResult dto for detection results with confidence - add DateValidator service for validating dates with format awareness - add date format detection to DataTypeInferencer - integrate date validation into CsvAnalyzer for date/datetime fields - add date format selector dropdown to review step ui - extend ColumnAnalysis with date format properties and helpers - extend ValueIssue with issue type for date ambiguity warnings
completely rewrites the import documentation to: - fix incorrect required fields (people: company_name is not required) - correct duplicate detection methods (only companies/people have non-id matching; opportunities, tasks, notes use id-only matching) - add comprehensive date format detection section explaining iso, european, and american formats with ambiguity handling - document company matching priority for people imports (id > domain > name) - simplify structure using tables instead of verbose prose - reduce file size by 40% while improving accuracy also fixes config/custom-fields.php to remove non-existent feature enum
add commonmark tableextension to markdown config so tables render as html instead of raw pipe-separated text also moves system_sections_enabled to disabled features in custom-fields
- Replace 5 overlapping docs with 4 focused guides - Add getting-started.md (actionable user onboarding) - Add developer-guide.md (streamlined technical docs) - Update api-guide.md with Coming Soon banner - Keep import-guide.md (already accurate) - Delete business-guide.md, quick-start-guide.md, technical-guide.md - Fix inaccuracies: auth is Jetstream not Fortify - Fix inaccuracies: Task/Note use morphToMany relationships - Remove non-existent keyboard shortcuts - Update config and icon mappings
3x/import wizard date formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.