You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
abdulazizali77
changed the title
MSB-265: Introduce upgrade list and db backup before upgrade
WIP MSB-265: Introduce upgrade list and db backup before upgrade
Dec 19, 2017
abdulazizali77
changed the title
WIP MSB-265: Introduce upgrade list and db backup before upgrade
MSB-265: Introduce upgrade list and db backup before upgrade
Dec 20, 2017
@vetss Sergey please have a look
-I have not added the new DB options to shell executor as i think it shouldnt be modifiable during runtime. What do you think?
-Do you think we should populate the dbLogindbPass in UssdProperties.xml or should we fetch it from the *-ds.xml? (not sure how to do that yet)
no manaual / CLI / GUI updates (let us do it further when all other staff became working)
when adding of new filelds into xml config files we may not add them into the end of the file (config files from old versions will not be loadable, this is an xml lib usage issue). So we need to add into a middle of the file
have you tested your code locally ? I mean prepare some database structure and run a server and check how will it make backups or database structure updates ? I have some doubts for example for module "checkUpgradePath()" does not push value "src" back to upper level.
you use a specific mysql staff. Let's test what will happen in case of another database, may be it will bring us some malfunctions. Ideally if we manage to reuse of staff that if universal for any database. For example "SELECT TABLE_NAME FROM INFORMATION_SCHEMA.COLUMNS" may be replaced by a "select from ***" and try to catch an Exception. All of this demands carefuly testing. You may add a unit test by the way.
I have not added the new DB options to shell executor as i think it shouldnt be modifiable during runtime. What do you think?
Such options may be modifyable during runtime for usage in the next start. We need to mention it in the manual.
Do you think we should populate the dbLogin dbPass in UssdProperties.xml or should we fetch it from the *-ds.xml? (not sure how to do that yet)
Login and pass - we can include it into an xml file. "*-ds.xml" is also an option but it may take efforts, not sure this is really needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.