Skip to content

Group by distinct records #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parrish wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Group by distinct records #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/restpack_serializer/serializable/side_load_data_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def side_load_belongs_to
def side_load_has_many
has_association_relation do |options|
if join_table = @association.options[:through]
options.scope = options.scope.joins(join_table).distinct
options.scope = options.scope.joins(join_table).group "#{options.scope.table_name}.id"
Copy link
Contributor Author

@parrish parrish Feb 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not immediately obvious (it wasn't to me anyway), but specifying the table name is necessary to avoid ambiguity with the joined table.

association_fk = @association.through_reflection.foreign_key.to_sym
options.filters = { join_table => { association_fk => model_ids } }
else
Expand Down