Fuzz iterators and fix bugs #335
Merged
+307
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Emann
force-pushed
the
fuzz_iterators_and_fix_bugs
branch
from
4da98bd to
6a782d3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Dr-Emann
force-pushed
the
fuzz_iterators_and_fix_bugs
branch
3 times, most recently
from
ecfb6a8 to
816954c
Compare
…onsume the whole thing Before, the iterator would be left alone, rather than consumed when calling `advance_to`/`advance_back_to` past all values in the container.
… of the only interval if present
Dr-Emann
force-pushed
the
fuzz_iterators_and_fix_bugs
branch
from
816954c to
497f5d9
Compare
include a debug assert to still catch the issues, but hopefully do less wrong behavior in release mode
Dr-Emann
force-pushed
the
fuzz_iterators_and_fix_bugs
branch
from
4819688 to
8becb4e
Compare
Kerollmops
approved these changes
Jul 26, 2025
Member
Kerollmops
left a comment
Kerollmops
left a comment
There was a problem hiding this comment.
Thank you very much for the fuzzer improvement, the tests, and the fixes. You rock 🤘
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to at least be able to pass for a while on fuzzing after these changes.