Skip to content

chore: set default type parameters to unknown in core classes #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EzraBrooks merged 1 commit into from
Jan 20, 2026
Merged

chore: set default type parameters to unknown in core classes #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/roslib/src/core/Service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ import { v4 as uuidv4 } from "uuid";
/**
* A ROS service client.
*/
export default class Service<TRequest, TResponse> extends EventEmitter {
export default class Service<
TRequest = unknown,
TResponse = unknown,
> extends EventEmitter {
/**
* Stores a reference to the most recent service callback advertised so it can be removed from the EventEmitter during un-advertisement
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/roslib/src/core/Topic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { v4 as uuidv4 } from "uuid";
* * 'warning' - If there are any warning during the Topic creation.
* * 'message' - The message data from rosbridge.
*/
export default class Topic<T> extends EventEmitter<{
export default class Topic<T = unknown> extends EventEmitter<{
message: [T];
warning: [string];
unsubscribe: undefined;
Expand Down