Skip to content

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Oct 27, 2025

Proposed changes (including videos or screenshots)

When an internal call ends, we now create a record on a per-user call history and detect the room id of the DM between the two users (creating it if it doesn't exist), so that we may send a message with the call's status on that room.

Issue(s)

VGA-49
VGA-50
VGA-53

Steps to test or reproduce

Further comments

The Call History itself will be expanded with API endpoints and a UI, as well as covering other types of calls too - but that work will be done with a different milestone; this PR simply adds the minimum history features needed to send the call messages on DMs.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 27, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

⚠️ No Changeset found

Latest commit: 0489d42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Oct 27, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/voip-call-history

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 17.54386% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.52%. Comparing base (9828d5c) to head (0489d42).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37316      +/-   ##
===========================================
- Coverage    67.61%   67.52%   -0.10%     
===========================================
  Files         3338     3338              
  Lines       113721   113774      +53     
  Branches     20662    20691      +29     
===========================================
- Hits         76895    76822      -73     
- Misses       34143    34269     +126     
  Partials      2683     2683              
Flag Coverage Δ
e2e 57.39% <ø> (-0.01%) ⬇️
e2e-api 40.34% <17.54%> (-0.16%) ⬇️
unit 71.49% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant