gccrs: fix segfault on empty doc attribute #4271
Merged
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We also need to fix #[doc = 1] should not work since 1 is not a string |
lucasly-ba
force-pushed
the
4226-segfault-empty-doc-attribute
branch
2 times, most recently
from
e6efc22 to
94d27fb
Compare
philberty
requested changes
Nov 13, 2025
Member
philberty
left a comment
philberty
left a comment
There was a problem hiding this comment.
build fails and not sure about your FIXME
gcc/rust/ChangeLog: * hir/rust-ast-lower-base.cc (ASTLoweringBase::handle_doc_item_attribute): Make error. gcc/testsuite/ChangeLog: * rust/compile/issue-4226.rs: New test. Signed-off-by: Lucas Ly Ba <[email protected]>
lucasly-ba
force-pushed
the
4226-segfault-empty-doc-attribute
branch
from
94d27fb to
a23fc2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4266
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: