Fix windows builds with --features use-bindgen
#1512
Merged
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
mastercommit does not compile with--features use-bindgen. Specifically, here:rust-sdl2/src/sdl2/keyboard/mod.rs
Line 194 in 0545cad
The compiler complains:
Clang generates different integer types for C-style enums on different platforms,
i32on Windows andu32on Linux. After some digging, there seems to be no neat way around this as far as I can tell, other than keeping this in mind whenever we care about the specific type of the underlying value.More info: rust-lang/rust-bindgen#1966
Also somewhat related to #1511, which is the original reason why I'm building with
use-bindgenin the first place.