Define intel-sde-install action#39
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Jun 1, 2024
Merged
Conversation
Member
|
A couple of yamllint failures: We could probably disable that lint, or at least turn it up. |
Member
|
@silvanshade would you still like to get this merged? |
Contributor
Author
|
Yeah this would still be needed to test the AVX512 features reliably on GitHub CI. |
Member
|
@silvanshade can you fix the lint failure? |
silvanshade
force-pushed
the
feature/intel-sde-install
branch
from
b37e4be to
7a5d96a
Compare
Contributor
Author
|
@tarcieri I added the override for the lint. I think it should be fixed now. |
tarcieri
approved these changes
Jun 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This action installs the intel software development emulator.
It is used in the CI job for the VAES backend in this PR.
The emulator is needed since GitHub Actions runners do not universally support AVX512.
QEMU could potentially be used as an alternative except that it does not support AVX512 and only recently has support for up to AVX2. Supposedly there is some support for VAES in recent versions but it may be limited to 256 variants. In any case, I could not get QEMU to work for this use case but Intel SDE works fine.
The reason for creating a separate action for this is because it may be useful for other crates intending to use recent
x86_64features. (I will likely submit more PRs making use of this at least.)